Eliminate dependency on .NET 10's non source-buildable Microsoft.AspNetCore.App.Internal.Assets package. #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmds
force-pushed
the
workaround_dotnet10_aspnet_issue
branch
4 times, most recently
from
52ecd15 to
d81de7b
Compare
…etCore.App.Internal.Assets package.
tmds
force-pushed
the
workaround_dotnet10_aspnet_issue
branch
from
d81de7b to
33a3da6
Compare
|
The tests run on 8.0 and 9.0 as well, will this have any impact on those? CI thinks they should be okay. If that's true, then okay by me. |
omajid
approved these changes
Jan 22, 2025
GitHub + internal CI will catch regressions introduced for 8.0 and 9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables running tests against .NET 10 build which are currently failing due to #368. Once the upstream issue is fixed, these changes can be reverted.