Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide country information based on the timezone #18

Closed
adietish opened this issue Mar 17, 2021 · 0 comments · Fixed by #19
Closed

provide country information based on the timezone #18

adietish opened this issue Mar 17, 2021 · 0 comments · Fixed by #19
Assignees

Comments

@adietish
Copy link
Contributor

Telemetry is not allowed to reverse map the user IP address to the country that this IP sources from. We thus have to guess the country by the timezone that the user machine is set to.
The equivalent implementation for vscode is based on https://github.com/manuelmhtr/countries-and-timezones:
https://github.com/redhat-developer/vscode-redhat-telemetry/blob/main/src/utils/platform-node.ts#L15

export const COUNTRY = getCountry(TIMEZONE);
@adietish adietish self-assigned this Mar 17, 2021
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Mar 17, 2021
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Mar 17, 2021
)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Mar 17, 2021
)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Mar 17, 2021
)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Mar 17, 2021
)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit that referenced this issue Mar 17, 2021
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant