Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associate validation, completion, etc with any language #26

Closed
angelozerr opened this issue Dec 4, 2023 · 0 comments · Fixed by #30
Closed

Associate validation, completion, etc with any language #26

angelozerr opened this issue Dec 4, 2023 · 0 comments · Fixed by #30
Labels
enhancement New feature or request
Milestone
0.0.1

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Dec 4, 2023 •
edited
Loading

Today the Intellij Plugin which want to support validation,hover, etc for a given language need to declare in the plugin.xml

Here a sample with Ij Quarkus and Qute_ language to display error for Qute:

<externalAnnotator language="Qute_"
                       implementationClass="com.redhat.devtools.lsp4ij.operations.diagnostics.LSPDiagnosticAnnotator"/>

It should be nice to avoid writting that:

  • it is boring
  • it can be dangerous, because if an Intellij Plugin defines externalAnnotator for Java language and an another Intellij Plugin defines the same externalAnnotator for language Java, validation will be duplicated.
  • it is required to support Add a language server without extension point #25

The only thing that we loose with this strategy is to control the order (before htmlText) of the completion that we use in IJ Quarkus:

<completion.confidence language="HTML" order="before htmlText" implementationClass="com.redhat.devtools.lsp4ij.operations.completion.LSPCompletionConfidence" />
@angelozerr angelozerr added the enhancement New feature or request label Dec 4, 2023
@angelozerr angelozerr mentioned this issue Dec 4, 2023
Open
@angelozerr angelozerr changed the title Associate validation, inlayHint, hover, etc with any language Associate validation, completion, etc with any language Dec 6, 2023
angelozerr added a commit to angelozerr/lsp4ij that referenced this issue Dec 6, 2023
@angelozerr
refactor: Associate validation, completion, etc with any language
42ba4ec 
Fixes redhat-developer#26

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Dec 6, 2023
Merged
angelozerr added a commit to angelozerr/lsp4ij that referenced this issue Dec 6, 2023
@angelozerr
refactor: Associate validation, completion, etc with any language
20cccd6 
Fixes redhat-developer#26

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr added this to the 0.0.1 milestone Dec 6, 2023
angelozerr added a commit that referenced this issue Dec 6, 2023
@angelozerr
refactor: Associate validation, completion, etc with any language
bfc2aa2 
Fixes #26

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr moved this to ✅ Done in IDE Cloudaptors Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
IDE Cloudaptors
Archived in project
Milestone
0.0.1
Development

Successfully merging a pull request may close this issue.

refactor: Associate validation, completion, etc with any language angelozerr/lsp4ij
1 participant
@angelozerr