Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow **Ctrl+Space** to toggle whether or not word completions are displayed #687

Merged

Conversation

SCWells72
Copy link
Contributor

Minor enhancement to the earlier LSP code completion enhancement such that word completions are not shown on auto-completion or odd completion trigger counts. This means that pressing Ctrl+Space repeatedly will now toggle word completions on and off but they won't be shown when there are LSP-based completions on auto-complete or initial explicit completion trigger.

Here's an example of the behavior with this change where you can see that there are not word completions by default, but pressing Ctrl+Space will toggle them on and off:

LSP_Word_Completions_Toggle

… that word completions are not shown on auto-completion or odd completion trigger counts. This means that pressing Ctrl+Space repeatedly will now toggle word completions on and off but they won't be shown when there are LSP-based completions on auto-complete or initial explicit completion trigger.
@angelozerr angelozerr merged commit f87d49b into redhat-developer:main Dec 11, 2024
6 checks passed
@angelozerr
Copy link
Contributor

Thanks @SCWells72

@angelozerr angelozerr added bug Something isn't working completion labels Dec 11, 2024
@angelozerr angelozerr added this to the 0.9.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants