Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure executing Query LSP implementation in ReadAction #690

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Dec 12, 2024

fix: ensure executing Query LSP implementation in ReadAction

The ReadAction is required when element.isValid() or element.getContaingFile() is called when element is a TreeElement (ex: Qute token).

@angelozerr angelozerr added the bug Something isn't working label Dec 12, 2024
@angelozerr angelozerr added this to the 0.9.0 milestone Dec 12, 2024
@angelozerr angelozerr self-assigned this Dec 12, 2024
@angelozerr angelozerr force-pushed the remove_isValid branch 2 times, most recently from 347a618 to 16aed31 Compare December 12, 2024 14:58
Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr changed the title fix: remove isValid which can require a ReadAcion when element is a TreeElement (ex: Qute token). fix: ensure executing Query LSP implementation in ReadAction Dec 12, 2024
@angelozerr angelozerr merged commit a29f4eb into redhat-developer:main Dec 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant