Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restoring VFS refresh of bundled JSON schema file #691

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

SCWells72
Copy link
Contributor

Unfortunately I can't use reloadPsi() for two reasons:

  1. There's not guaranteed to be a non-null Project when the JSON schema is loaded because it's loaded via a project-independent extension point.
  2. reloadPsi() uses FileManagerImpl which is annotated as @ApiStatus.Internal and therefore almost certainly won't be accepted by JetBrains in a new plugin version submission. That likely needs to change to do something different, perhaps just what I'm doing here with a two-phase VFS refresh.

@angelozerr angelozerr merged commit fb555b2 into redhat-developer:main Dec 12, 2024
6 checks passed
@angelozerr
Copy link
Contributor

Thanks @SCWells72 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants