Mac-pool service #377
Open
Mac-pool service #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianriobo
force-pushed
the
fix-376
branch
5 times, most recently
from
2bbc0f2 to
a2e5446
Compare
Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
previously init functions for context had bunch of parameters which were hard to set with default values, this commit includes a struct to hold all possible params, also the contxt initalization has been moved from cmds to actions improving the design of the solution, as cmd code should have no logic at all and act only as wrapper to invoke action Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
this commit will change several deatils around the mac-pool workflow and the expectation on how the values for the machine should be treated Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #376
Depends on #352