Skip to content

Commit

Permalink
Downgrade and pin the versions of 'sigs.k8s.io/controller-runtime' an…
Browse files Browse the repository at this point in the history
…d 'k8s.io/*' to the previous versions we had

Bumping Alizer bumped these packages to upper versions,
which seems to cause build errors due to Service Binding Operator
libraries not compatible with those new versions.
See the error below.

Since we don't want to update SBO libraries at this time
(as SBO is currently in maintenance mode only),
this makes sure we are using the versions it builds against.

Build error for reference:
```
go install -mod=vendor -ldflags="-X github.com/redhat-developer/odo/pkg/version.GITCOMMIT=cb9c13900" ./cmd/odo/
# github.com/redhat-developer/service-binding-operator/apis/spec/v1alpha3
vendor/github.com/redhat-developer/service-binding-operator/apis/spec/v1alpha3/servicebinding_webhook.go:44:27: cannot use &ServiceBinding{} (value of type *ServiceBinding) as type admission.Validator in variable declaration:
        *ServiceBinding does not implement admission.Validator (wrong type for ValidateCreate method)
                have ValidateCreate() error
                want ValidateCreate() (warnings admission.Warnings, err error)
# github.com/redhat-developer/service-binding-operator/apis/binding/v1alpha1
vendor/github.com/redhat-developer/service-binding-operator/apis/binding/v1alpha1/servicebinding_webhook.go:37:27: cannot use &ServiceBinding{} (value of type *ServiceBinding) as type admission.Validator in variable declaration:
        *ServiceBinding does not implement admission.Validator (wrong type for ValidateCreate method)
                have ValidateCreate() error
                want ValidateCreate() (warnings admission.Warnings, err error)
make: *** [Makefile:90: install] Error 2
```
  • Loading branch information
rm3l committed Jun 23, 2023
1 parent 2a91cfd commit 3a76856
Show file tree
Hide file tree
Showing 576 changed files with 22,313 additions and 36,651 deletions.
13 changes: 13 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -216,3 +216,16 @@ require (
replace gopkg.in/segmentio/analytics-go.v3 => github.com/segmentio/analytics-go/v3 v3.2.1

replace github.com/apcera/gssapi => github.com/openshift/gssapi v0.0.0-20161010215902-5fb4217df13b

// We are pinning the versions here because bumping Alizer bumped these packages to upper versions,
// which were not compatible with the Service Binding Operator (SBO) version at this time.
// Example error: *ServiceBinding does not implement admission.Validator (wrong type for ValidateCreate method)
// But we don't want to update SBO libraries at this time, as SBO is currently in maintenance mode only.
// TODO(rm3l): remove these when we remove support for SBO.
replace (
k8s.io/api => k8s.io/api v0.26.1
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.26.1
k8s.io/apimachinery => k8s.io/apimachinery v0.26.1
k8s.io/client-go => k8s.io/client-go v0.26.1
sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.14.4
)
327 changes: 172 additions & 155 deletions go.sum

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

484 changes: 80 additions & 404 deletions vendor/k8s.io/api/admissionregistration/v1/generated.pb.go

Large diffs are not rendered by default.

73 changes: 0 additions & 73 deletions vendor/k8s.io/api/admissionregistration/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

73 changes: 0 additions & 73 deletions vendor/k8s.io/api/admissionregistration/v1/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 3a76856

Please sign in to comment.