Skip to content

Commit

Permalink
Clarifies 1 code reviewer, 1 approver (#3080)
Browse files Browse the repository at this point in the history
**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

Updates the development.adoc documentation with regards to having 1 code
reviewer and 1 approver.

**Which issue(s) this PR fixes**:

N/A

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
  • Loading branch information
cdrage authored May 5, 2020
1 parent 3d7212b commit 7010f4d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/dev/development.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ Read the Makefile itself for more information.
=== PR review process

. Once you submit a PR, the @openshift-ci-robot automatically requests two reviews from reviewers and suggests an approver based on `OWNERS` files.
. After a reviewer is satisfied with the changes he adds `/lgtm` (looks good to me) as a comment to the PR. This applies the *lgtm* label.
. The approver then reviews the PR and if satisfied, adds
`/approve` as a comment to the PR. This applies the *approve* label.
. Each PR requires *one* code review (lgtm label) and *one* approve (approved label).
. After a code reviewer is satisfied with the changes he adds `/lgtm` (looks good to me) as a comment to the PR. Which applies the *lgtm* label.
. The approver reviews the PR and if satisfied, adds `/approve` as a comment to the PR. Which applies the *approve* label.
* After the PR has *lgtm* and *approve* labels and the required tests pass, the bot automatically merges the PR.
+
NOTE: If you are a maintainer and have write access to the `odo` repository, modify your git configuration so that you do not accidentally push to upstream:
Expand Down

0 comments on commit 7010f4d

Please sign in to comment.