Change the default PVC size of 1Gi to 10Gi

[cdrage]

/kind enhancement

Which functionality do you think we should update/improve?

It's 2019, even my phone comes with 32Gb already included ;)

I tried running: https://github.com/gothinkster/vue-realworld-example-app

and found that I encountered an error of running out of space within the Node.js application. I checked PVC and found that we only use 1Gi!

https://github.com/openshift/odo/blob/master/pkg/occlient/occlient.go#L1194

I suggest we:

• Change the default to 10Gi
• Allow the ability to set the default PVC similar to how we can set the minimum CPU and memory size.
• Remove the hardcoded variables of 1Gi!

Why is this needed?

Because 1Gi isn't enough at all

[openshift-ci-robot]

@cdrage: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them

In response to this:

/kind enhancement

Which functionality do you think we should update/improve?

It's 2019, even my phone comes with 32Gb already included ;)

I tried running: https://github.com/gothinkster/vue-realworld-example-app

and found that I encountered an error of running out of space within the Node.js application. I checked PVC and found that we only use 1Gi!

https://github.com/openshift/odo/blob/master/pkg/occlient/occlient.go#L1194

I suggest we:

• Change the default to 10Gi
• Allow the ability to set the default PVC similar to how we can set the minimum CPU and memory size.

Why is this needed?

Because 1Gi isn't enough at all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@cdrage: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them

In response to this:

/kind enhancement

Which functionality do you think we should update/improve?

It's 2019, even my phone comes with 32Gb already included ;)

I tried running: https://github.com/gothinkster/vue-realworld-example-app

and found that I encountered an error of running out of space within the Node.js application. I checked PVC and found that we only use 1Gi!

https://github.com/openshift/odo/blob/master/pkg/occlient/occlient.go#L1194

I suggest we:

• Change the default to 10Gi
• Allow the ability to set the default PVC similar to how we can set the minimum CPU and memory size.
• Remove the hardcoded variables of 1Gi!

Why is this needed?

Because 1Gi isn't enough at all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kadel]

@cdrage do you have a suggestion on how the configuration should look like?

[kadel]

not sure about changing the default - see #755

[girishramnani]

we can make this PVC Size configurable? maybe a preference? suggestion on param name ComponentVolumeSize

[cdrage]

@kadel Yup. See initial description, I suggest we: Allow the ability to set the default PVC similar to how we can set the minimum CPU and memory size.

[girishramnani]

Then I would suggest to keep the PVC size to 1Gi and allow it to change. 10Gi is too big.

[kadel]

/close
in favor of #2616

[openshift-ci-robot]

@kadel: Closing this issue.

In response to this:

/close
in favor of #2616

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.