Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the size of a component's volume to be specified in a Devfile #14

Closed
johnmcollier opened this issue Feb 5, 2020 · 3 comments · Fixed by #35
Closed

Allow the size of a component's volume to be specified in a Devfile #14

johnmcollier opened this issue Feb 5, 2020 · 3 comments · Fixed by #35
Milestone
2.0

Comments

@johnmcollier
Copy link
Member

johnmcollier commented Feb 5, 2020 •
edited by l0rd
Loading

Right now, there isn’t a way to specify the size of a component’s volume in a devfile, and Che will use the size specified in che.properties (default 1Gi). As different component-types may have different volume requirements (e.g. the issue seen in redhat-developer/odo#2455), Odo will have a need to specify the size of volumes it interacts with, and rather than having an odo-specific setting, it would be nice if we could store this setting in the devfile,

This change might also be nice for Che, as it would allow components to configure the size of volumes they need (such as a maven cache volume that requires more than 1Gi), rather than relying on global Che defaults.

Something like:

---
components:
  - container:
      image: "maven"
      name: "maven"
      volumesMount: 
      - name: my-data-volume
  - volume:
     name: my-data-volume
     size: 5Gi
@l0rd l0rd mentioned this issue Feb 5, 2020
Closed
28 tasks
@l0rd
Copy link
Contributor

l0rd commented Feb 18, 2020 •
edited
Loading

Proposal reviewed and approved.

@kadel kadel mentioned this issue Mar 2, 2020
Closed
@l0rd
Copy link
Contributor

l0rd commented Apr 7, 2020

Updated the sample based on the new volume spec #19

davidfestal added a commit that referenced this issue Apr 10, 2020
@davidfestal
Implement agreement on issue #14 and #19
2b3097f 
Signed-off-by: David Festal <dfestal@redhat.com>
@elsony elsony mentioned this issue Apr 20, 2020
Closed
12 tasks
davidfestal added a commit that referenced this issue Apr 22, 2020
@davidfestal @sleshchenko
Implement agreed-on devfile 2.0 issues (#35)
f9e7352 
* Implement agreement on issue #18
* Implement agreement on issue #17
* Implement agreement on issue #21
* Implement agreement on issue #22
* Implement agreement on issue #27
* Implement agreement on issue #9
* Implement agreement on issue #10
* Fix PR comments about issue #9 PR comment #35 (comment)
* Fix PR comments about issue #17 PR comment #35 (comment)
* Implement agreement on issue #14 and  #19
* Add the spring boot example
* Implement agreement on issue #32
* Fix last PR comments

Signed-off-by: David Festal <dfestal@redhat.com>

Co-Authored-By: Sergii Leshchenko <sleshche@redhat.com>
@l0rd l0rd added this to the 2.0.0 milestone Jun 16, 2020
@davidfestal davidfestal linked a pull request Jun 23, 2020 that will close this issue
Implement agreed-on devfile 2.0 issues #35
Merged
@davidfestal
Copy link
Collaborator

Implemented

@elsony elsony mentioned this issue Jun 23, 2020
Closed
2 tasks
@l0rd l0rd mentioned this issue Sep 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Implement agreed-on devfile 2.0 issues devfile/api
3 participants
@l0rd @davidfestal @johnmcollier