Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devfile v2 support for odo push (k8s and OpenShift) #3140

Closed
4 tasks done
kadel opened this issue May 11, 2020 · 3 comments · Fixed by #3216
Closed
4 tasks done

devfile v2 support for odo push (k8s and OpenShift) #3140

kadel opened this issue May 11, 2020 · 3 comments · Fixed by #3216
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. area/kubernetes Issues or PRs related to Kubernetes area/openshift Issues or PRs related to OpenShift kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@kadel
Copy link
Member

kadel commented May 11, 2020

/kind user-story

User Story

As an odo user, I want to be able to use devfile.yaml defined using v2 spec

Acceptance Criteria

  • odo push should autodetect devfile.yaml version
  • odo push It should create Deployment with containers and Services based on the devfile.yaml v2 containers definition
  • odo push should create URL (Route or Ingress) based on devfile v2 definition
  • odo push should create storage for storage defined in devfile v2

above is relevant for odo preference set pushtarget kube

some examples of devfile v2 https://github.com/sbose78/stack-registry/tree/sbose78-patch-1/stacks

Links

#3145 handles this for Docker (local pustarget)

/kind user-story
/area devfilev2
/area devfile
/priority high

@openshift-ci-robot openshift-ci-robot added kind/user-story An issue of user-story kind area/devfileV2 area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels May 11, 2020
@girishramnani
Copy link
Contributor

We need to consider if odo push support for docker for devfile v2 needs to be a different issue or not.

@kadel
Copy link
Member Author

kadel commented May 11, 2020

/priority high

@openshift-ci-robot openshift-ci-robot added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label May 11, 2020
@kadel kadel changed the title devfile v2 support for odo push devfile v2 support for odo push (k8s and OpenShift) May 11, 2020
@kadel kadel added area/kubernetes Issues or PRs related to Kubernetes area/openshift Issues or PRs related to OpenShift labels May 11, 2020
@kadel
Copy link
Member Author

kadel commented May 11, 2020

We need to consider if odo push support for docker for devfile v2 needs to be a different issue or not.

good point. I've created #3145 to address the local (docker) case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. area/kubernetes Issues or PRs related to Kubernetes area/openshift Issues or PRs related to OpenShift kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants