Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin down the version of ginkgo on CI scripts #3361

Closed
girishramnani opened this issue Jun 16, 2020 · 10 comments
Closed

pin down the version of ginkgo on CI scripts #3361

girishramnani opened this issue Jun 16, 2020 · 10 comments
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/user-story An issue of user-story kind lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.

Comments

@girishramnani
Copy link
Contributor

/kind user-story

User Story

pin down the version of ginkgo on CI scripts so that an upgrade doesn't give us unexpected failures

Links

/kind user-story
@openshift-ci-robot openshift-ci-robot added the kind/user-story An issue of user-story kind label Jun 16, 2020
@girishramnani
Copy link
Contributor Author

@amitkrout please take a look at his story.

@girishramnani
Copy link
Contributor Author

I will be pinning down the wwhrd and gosec versions as part of this issue #3359

@kadel
Copy link
Member

kadel commented Jun 16, 2020

/area testing

@openshift-ci-robot openshift-ci-robot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Jun 16, 2020
@amitkrout amitkrout mentioned this issue Jul 29, 2020
Closed
3 tasks
@amitkrout
Copy link
Contributor 

+ go install github.com/onsi/ginkgo/ginkgo
build github.com/onsi/ginkgo/ginkgo: cannot load github.com/fsnotify/fsnotify: open /go/src/github.com/onsi/ginkgo/vendor/github.com/fsnotify/fsnotify: no such file or directory

Hitting the failure due the flag GOFLAGS="-mod=vendor”. This will be fixed just by overwriting it for example

go install -mod=“” github.com/onsi/ginkgo/ginkgo

Tomorrow I will fix it and open the pr #3657 for review.

@girishramnani girishramnani added priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) labels Aug 5, 2020
@kadel
Copy link
Member

kadel commented Aug 20, 2020

@girishramnani girishramnani added priority/Low status/blocked labels 15 days ago

why is this blocked?

@amitkrout
Copy link
Contributor

@girishramnani girishramnani added priority/Low status/blocked labels 15 days ago

why is this blocked?

#3700

@amitkrout
Copy link
Contributor

I am un assigning myself here as it blocked by #3700. And i am not actively working on this too since couple of weeks.

@amitkrout amitkrout removed their assignment Aug 20, 2020
@kadel
Copy link
Member

kadel commented Sep 2, 2020

/remove-status blocked

#3700 has been resolved so this is no longer blocked

@kadel kadel removed the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Sep 2, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2020
@girishramnani
Copy link
Contributor Author

It seems this was done when we moved to go mod
https://github.com/openshift/odo/blob/9200a7f99c2627c64d8ea2145aecf3ea2868d244/Makefile#L109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/user-story An issue of user-story kind lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Pin down ginkgo version amitkrout/odo
5 participants
@kadel @openshift-bot @girishramnani @amitkrout @openshift-ci-robot