Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test command integration tests fail for docker adapter #3685

Closed
metacosm opened this issue Aug 4, 2020 · 4 comments
Closed

Test command integration tests fail for docker adapter #3685

metacosm opened this issue Aug 4, 2020 · 4 comments
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@metacosm
Copy link
Contributor

metacosm commented Aug 4, 2020 •
edited
Loading

/kind bug

What versions of software are you using?

Operating System: macOS 10.15.6

Output of odo version: odo v1.2.4 (5163834)

How did you run odo exactly?

ginkgo tests/integration/devfile/docker/ and executing the same commands manually. Note that the corresponding tests pass for the kubernetes adapter: https://github.com/openshift/odo/runs/942000996

Actual behavior

The test command ITs ("Should run test command successfully") fail while the manual command execution seem to reflect the tests expectations.

Expected behavior

Either both ITs and manual execution fail or both succeed. Not a combination of both… :)

Any logs, error output, etc?

• Failure [20.213 seconds]
odo docker devfile test command tests
/Users/claprun/Dev/go/src/github.com/openshift/odo/tests/integration/devfile/docker/cmd_docker_devfile_test_test.go:14
  Should run test command successfully
  /Users/claprun/Dev/go/src/github.com/openshift/odo/tests/integration/devfile/docker/cmd_docker_devfile_test_test.go:114
    Should run test command successfully with only one default specified [It]
    /Users/claprun/Dev/go/src/github.com/openshift/odo/tests/integration/devfile/docker/cmd_docker_devfile_test_test.go:116

    Expected
        <string>: total 32
        drwxr-xr-x 3 root root  4096 Aug  4 08:23 .
        drwxr-xr-x 1 root root  4096 Aug  4 08:23 ..
        -rw------- 1  501 games   93 Aug  4 08:23 .gitignore
        -rw-r--r-- 1  501 games  218 Aug  4 08:23 config.yaml
        -rw-r--r-- 1  501 games 1191 Aug  4 08:23 devfile.yaml
        -rw-r--r-- 1  501 games  395 Aug  4 08:23 package.json
        -rw-r--r-- 1  501 games 1903 Aug  4 08:23 server.js
        drwxr-xr-x 2 root root  4096 Aug  4 08:23 test
        
    to contain substring
        <string>: test1

    /Users/claprun/Dev/go/src/github.com/openshift/odo/tests/integration/devfile/docker/cmd_docker_devfile_test_test.go:129
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 4, 2020
metacosm added a commit to metacosm/odo that referenced this issue Aug 4, 2020
@metacosm
fix: comment out failing tests
95ba568 
See redhat-developer#3685
@elsony elsony added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Aug 5, 2020
metacosm added a commit to metacosm/odo that referenced this issue Aug 6, 2020
@metacosm
fix: comment out failing tests
f035f8f 
See redhat-developer#3685
metacosm added a commit to metacosm/odo that referenced this issue Aug 6, 2020
@metacosm
fix: comment out failing tests
97382d7 
See redhat-developer#3685
openshift-merge-robot pushed a commit that referenced this issue Aug 7, 2020
@metacosm
refactor: simplify execution of devfile commands (#3596)
412f588 
* refactor: simplify execution of devfile commands

Fixes #3518

* fix: remove mistakenly re-added PlatformAdapter interface

* refactor: move catalog list output to where it's actually needed

This simplifies the package organization by avoiding to import catalog-
related packages in the lower-level machine output package.

* feat: add LoggingClient method on ComponentAdapter interface

* refactor: rename all receivers similarly

* fix: typo

* refactor: ComponentAdapter implements ExecClient, simplify Execute

* fix: typo

* refactor: introduce GenericAdapter to share more code

* chore: remove now unneeded methods

* fix: update from master

* fix: improper code to ExecuteCommand

* fix: properly initialize Client in adapters

* fix: update tests

* chore: add docs [skip ci]

* refactor: expose component info factory methods

* feat: add ExplicitSpinner function

* refactor: simplify adapters using NewMachineEventLoggingClient factory

* refactor: introduce command concept following the composite pattern

Still needs a lot of work to accommodate composite-support changes

* refactor: re-implement command execution using composite commands

* refactor: re-organize command implementations in multiple files

* doc: document New and command

* fix: typo

* fix: change var name

* fix: improper check for composite command

* clean-up: unneeded code

* refactor: rename ExecuteDevfileCommandSynchronously more appropriately

* chore: re-add some tests

* fix: init the ComponentInfoFactories after the GenericAdapter is created

This is needed because the previous implementation resulted in the
componentInfo and supervisorComponentInfo variables capturing
uninitialized adapters and thus causing errors.

* chore: add documentation

* fix: use Errorf instead of Wrapf since there is no error to wrap

* fix: infinite loop

* fix: do not report an error if the supervisor container is not found

* fix: only start the supervisor if we found its container

* fix: remove redundant check

* fix: supervisor commands now use proper component info

Introduced newSupervisor*Command to encapsulate supervisor command
details.

* fix: do not add to composite if supervisor command is nil

* fix: supervisor start/stop should be more like regular simple commands

* fix: add newline at the end of output

* doc: add documentation

[skip ci]

* refactor: rename createFrom to createCommandFrom

* refactor: make sourcePath a const and move it where it's used

* fix: comment out failing tests

See #3685

* fix: typo

* doc: clarify simpleCommand's behavior with respect to commands

[skip ci]

* feat: do not show spinner if message is empty

* fix: do not show spinner for stop command

* fix: remove unneeded fmt.Sprintf call

* chore: update after rebase
cdrage pushed a commit to cdrage/odo that referenced this issue Aug 7, 2020
@metacosm @cdrage
refactor: simplify execution of devfile commands (redhat-developer#3596)
0540cc1 
* refactor: simplify execution of devfile commands

Fixes redhat-developer#3518

* fix: remove mistakenly re-added PlatformAdapter interface

* refactor: move catalog list output to where it's actually needed

This simplifies the package organization by avoiding to import catalog-
related packages in the lower-level machine output package.

* feat: add LoggingClient method on ComponentAdapter interface

* refactor: rename all receivers similarly

* fix: typo

* refactor: ComponentAdapter implements ExecClient, simplify Execute

* fix: typo

* refactor: introduce GenericAdapter to share more code

* chore: remove now unneeded methods

* fix: update from master

* fix: improper code to ExecuteCommand

* fix: properly initialize Client in adapters

* fix: update tests

* chore: add docs [skip ci]

* refactor: expose component info factory methods

* feat: add ExplicitSpinner function

* refactor: simplify adapters using NewMachineEventLoggingClient factory

* refactor: introduce command concept following the composite pattern

Still needs a lot of work to accommodate composite-support changes

* refactor: re-implement command execution using composite commands

* refactor: re-organize command implementations in multiple files

* doc: document New and command

* fix: typo

* fix: change var name

* fix: improper check for composite command

* clean-up: unneeded code

* refactor: rename ExecuteDevfileCommandSynchronously more appropriately

* chore: re-add some tests

* fix: init the ComponentInfoFactories after the GenericAdapter is created

This is needed because the previous implementation resulted in the
componentInfo and supervisorComponentInfo variables capturing
uninitialized adapters and thus causing errors.

* chore: add documentation

* fix: use Errorf instead of Wrapf since there is no error to wrap

* fix: infinite loop

* fix: do not report an error if the supervisor container is not found

* fix: only start the supervisor if we found its container

* fix: remove redundant check

* fix: supervisor commands now use proper component info

Introduced newSupervisor*Command to encapsulate supervisor command
details.

* fix: do not add to composite if supervisor command is nil

* fix: supervisor start/stop should be more like regular simple commands

* fix: add newline at the end of output

* doc: add documentation

[skip ci]

* refactor: rename createFrom to createCommandFrom

* refactor: make sourcePath a const and move it where it's used

* fix: comment out failing tests

See redhat-developer#3685

* fix: typo

* doc: clarify simpleCommand's behavior with respect to commands

[skip ci]

* feat: do not show spinner if message is empty

* fix: do not show spinner for stop command

* fix: remove unneeded fmt.Sprintf call

* chore: update after rebase
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 27, 2021
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Collaborator

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@metacosm @openshift-bot @girishramnani @elsony @openshift-ci-robot