Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip starter projects should not require URLs ending with .zip #3853

Closed
metacosm opened this issue Aug 27, 2020 · 0 comments · Fixed by #3854
Closed

zip starter projects should not require URLs ending with .zip #3853

metacosm opened this issue Aug 27, 2020 · 0 comments · Fixed by #3854
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@metacosm
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System: macOS 10.15.6

Output of odo version: odo v1.2.5 (0780a6b)

How did you run odo exactly?

odo create --devfile ../devfile.yaml --starter=foo with a devfile I created explicitly to have several starter zip projects

Actual behavior

✗ Invalid zip url: <url that doesn't end with .zip>

Expected behavior

If the URL points to a non-zip file, it should only fail when trying to unzip it, not prevent people from using URLs that don't end in .zip

Any logs, error output, etc?

See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants