Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odo installation on windows is broken #4062

Closed
gorkem opened this issue Sep 30, 2020 · 4 comments · Fixed by #4176
Closed

odo installation on windows is broken #4062

gorkem opened this issue Sep 30, 2020 · 4 comments · Fixed by #4176
Assignees
@rnapoles-rh
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@gorkem
Copy link
Contributor

gorkem commented Sep 30, 2020

/kind bug

There are multiple issues with windows installation.

  1. There are 2 distributions for windows one .exe and .tar.gz unfortunately windows does not come with tools to handle tar.gz by default. We should produce .zip files for windows like we do for crc.

  2. I think there is a mismatch with the instructions and the filenames. Instructions refer to a odo.exe while linking to odo-windows-amd64.exe. There are no instructions to rename this file.

  3. Step 2 on the installation instructions refers to a GOPATH which is not something most windows users would have configured.
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 30, 2020
@girishramnani girishramnani added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Oct 5, 2020
@girishramnani girishramnani mentioned this issue Oct 5, 2020
Closed
@girishramnani girishramnani added the triage/needs-information Indicates an issue needs more information in order to work on it. label Oct 27, 2020
@rnapoles-rh rnapoles-rh linked a pull request Oct 29, 2020 that will close this issue
#4062 Update installing odo on Windows section to fix filename and ad… #4176
Merged
1 task
@rnapoles-rh
Copy link
Contributor

Regarding item 1- ... we should produce .zip files for windows like we do for crc., since we provide an executable file for download, it would be silly to provide a zip file as it adds an extra step for the user to unzip the executable. We will not provide a zip file. Unless anyone disagrees.

@gorkem
Copy link
Contributor Author

gorkem commented Oct 29, 2020

We are already providing a tar.gz in addition to the .exe are you suggesting that we do not provide the tar.gz going forward?

@deboer-tim
Copy link

To be clear, the request was to produce a .zip instead of .tar.gz (i.e. just change the compression format), not a new/second file.

@girishramnani girishramnani mentioned this issue Oct 30, 2020
Merged
1 task
@mohammedzee1000
Copy link
Contributor

mohammedzee1000 commented Nov 13, 2020 •
edited
Loading

Required changes:

  1. Update logic https://github.com/openshift/odo/blob/master/scripts/prepare-release.sh#L24-L41 to use gzip for windows and tar.gz otherwise
  2. Update to copy .zip files as well https://github.com/openshift/odo/blob/master/rpms/openshift-odo.spec#L63
  3. Update tar.gz to zip https://github.com/openshift/odo/blob/master/rpms/openshift-odo.spec#L95
  4. Review test script https://github.com/openshift/odo/blob/master/scripts/rpm-x86_64-test.sh for changes

openshift-merge-robot pushed a commit that referenced this issue Dec 18, 2020
@rnapoles-rh
#4062 Update installing odo on Windows section to fix filename and ad… (
051ad88 
#4176)

* #4062 Update installing odo on Windows section to fix filename and add additional steps and information required

* #4062 updated to make it generic, got rid of go/bin references

* Incorporated feedback from dharmit

* #4062 made changes to replace tar.gz for .zip for windows installer

* #4062 incorporated feedback from Dharmit

* #4062 Fixed a couple of typos to addres dharmit feedback

* 4062 fix mising dot in .exe

* 4062 fix if sattement

* 4062 fix syntax error

* 4062 fix syntax error

* 4062 fix syntax error

* 4062 fix syntax error

* 4062 fix syntax error

* Fixed statements for when suffix is .exe

* Fixed if syntax

* changed syntax

* Fixed syntax

* fixed zip command syntax

* Removed unnecessary comments and updtaed redistributable filename to add .exe before .zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnapoles-rh rnapoles-rh

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4062 Update installing odo on Windows section to fix filename and ad…
7 participants
@gorkem @girishramnani @mohammedzee1000 @Preeticp @deboer-tim @openshift-ci-robot @rnapoles-rh