Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odo CI shoud not run "v4.6-e2e-4x-psi" check for Docs PRs #4439

Closed
dharmit opened this issue Feb 17, 2021 · 6 comments
Closed

odo CI shoud not run "v4.6-e2e-4x-psi" check for Docs PRs #4439

dharmit opened this issue Feb 17, 2021 · 6 comments
Assignees
@prietyc123
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering

Comments

@dharmit
Copy link
Member

dharmit commented Feb 17, 2021

Documentation PRs are going through "v4.6-e2e-4x-psi" test even though skip-ci is mentioned. I think that we don't have to provide skip-ci any more for the CI to skip other checks. We need to make changes to ensure that "v4.6-e2e-4x-psi" and subsequent tests on PSI for 4.7 and so on do not get executed either.

/area testing
@openshift-ci-robot openshift-ci-robot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Feb 17, 2021
@dharmit
Copy link
Member Author

dharmit commented Feb 17, 2021

@anandrkskd can you help with this?

@dharmit
Copy link
Member Author

dharmit commented Feb 17, 2021

One such reference of CI running for docs PR is #4434.

@anandrkskd
Copy link
Contributor

anandrkskd commented Feb 17, 2021 •
edited
Loading

Yes, we don't need to mention skip-ci to skip running tests on cluster. I guess the other tests also executed because the current regex only skips any docs related change under /docs dir.
And we have not added that on our PSI tests, I will make sure my PR will adds that and skips the tests.

@prietyc123
Copy link
Contributor

And we have not added that on our PSI tests

I think it will get fixed once we add doc check in v4.6-e2e-4x-psi job. PR openshift/release#16274 should fix this as well.

@prietyc123 prietyc123 self-assigned this Feb 25, 2021
@anandrkskd
Copy link
Contributor

anandrkskd commented Feb 25, 2021 •
edited
Loading

I have added the required change for this issue on my recent PR as well :( I think we should have a conversation on this @prietyc123

@prietyc123
Copy link
Contributor

This has been done by pr openshift/release#16274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prietyc123 prietyc123

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dharmit @openshift-ci-robot @anandrkskd @prietyc123