Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 4.7 ocp cluster on prs #16274

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

prietyc123
Copy link
Contributor

@prietyc123
Copy link
Contributor Author

/retest

@prietyc123
Copy link
Contributor Author

/test pj-rehearse

@prietyc123
Copy link
Contributor Author

/retest

@mik-dass
Copy link

mik-dass commented Mar 1, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
Comment on lines 48 to 63
- artifact_dir: /tmp/artifacts
as: e2e-4x-psi
steps:
test:
- as: e2e-4x-psi-steps
commands: sh scripts/openshiftci-e2e-4x-psi-tests.sh
credentials:
- mount_path: /usr/local/ci-secrets/odo-rabbitmq
name: odo-rabbitmq
namespace: test-credentials
env:
- default: /usr/local/ci-secrets/odo-rabbitmq/amqpuri
name: ODO_RABBITMQ_AMQP_URL
from: oc-bin-image
resources:
requests:
cpu: "2"
memory: 6Gi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prietyc123 why are we moving PSI test related yaml to 4.7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is of no reason but just because I thought to maintain only the periodic job configuration for the previous build other than latest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be hard to track then coz my PR adds the configuration at 4.6.
And it will become an extra effort if we start moving all the psi test to newer config file.
I think we should maintain only one file for PSI, i.e. openshift-odo-master__v4.6.yaml, then it will be easy to track.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will become an extra effort if we start moving all the psi test to newer config file.
I think we should maintain only one file for PSI, i.e. openshift-odo-master__v4.6.yaml

IMO it would a great idea if we maintain psi thing inside openshift-odo-master.yaml rather openshift-odo-master__v4.x.yaml . Anyway we have this in plan for further psi configuration. @mohammedzee1000 correct me if I am wrong.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2021

@prietyc123: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse b852705543d8ad66e43594def28fbdc7ff83e494 link /test pj-rehearse
ci/rehearse/openshift/odo/master/v4.7-e2e-4x-psi 57ba14f link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass, mohammedzee1000, prietyc123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e8471ab into openshift:master Mar 1, 2021
@openshift-ci-robot
Copy link
Contributor

@prietyc123: Updated the following 3 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-odo-master-presubmits.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-odo-master-presubmits.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-odo-master__v4.6.yaml using file ci-operator/config/openshift/odo/openshift-odo-master__v4.6.yaml
    • key openshift-odo-master__v4.7.yaml using file ci-operator/config/openshift/odo/openshift-odo-master__v4.7.yaml

In response to this:

ping @mohammedzee1000 @kadel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadel
Copy link
Member

kadel commented Mar 1, 2021

rehearse checks are failing and tide status is tide Not mergeable. How is it possible that this got merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants