-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 4.7 ocp cluster on prs #16274
Enable 4.7 ocp cluster on prs #16274
Conversation
/retest |
/test pj-rehearse |
/retest |
/approve |
- artifact_dir: /tmp/artifacts | ||
as: e2e-4x-psi | ||
steps: | ||
test: | ||
- as: e2e-4x-psi-steps | ||
commands: sh scripts/openshiftci-e2e-4x-psi-tests.sh | ||
credentials: | ||
- mount_path: /usr/local/ci-secrets/odo-rabbitmq | ||
name: odo-rabbitmq | ||
namespace: test-credentials | ||
env: | ||
- default: /usr/local/ci-secrets/odo-rabbitmq/amqpuri | ||
name: ODO_RABBITMQ_AMQP_URL | ||
from: oc-bin-image | ||
resources: | ||
requests: | ||
cpu: "2" | ||
memory: 6Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prietyc123 why are we moving PSI test related yaml to 4.7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is of no reason but just because I thought to maintain only the periodic job configuration for the previous build other than latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be hard to track then coz my PR adds the configuration at 4.6.
And it will become an extra effort if we start moving all the psi test to newer config file.
I think we should maintain only one file for PSI, i.e. openshift-odo-master__v4.6.yaml
, then it will be easy to track.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will become an extra effort if we start moving all the psi test to newer config file.
I think we should maintain only one file for PSI, i.e. openshift-odo-master__v4.6.yaml
IMO it would a great idea if we maintain psi thing inside openshift-odo-master.yaml
rather openshift-odo-master__v4.x.yaml
. Anyway we have this in plan for further psi configuration. @mohammedzee1000 correct me if I am wrong.
b852705
to
57ba14f
Compare
@prietyc123: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mik-dass, mohammedzee1000, prietyc123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@prietyc123: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rehearse checks are failing and tide status is |
ping @mohammedzee1000 @kadel