Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting application makes it look like it failure #6486

Closed
kadel opened this issue Jan 12, 2023 · 3 comments · Fixed by #7011
Closed

Restarting application makes it look like it failure #6486

kadel opened this issue Jan 12, 2023 · 3 comments · Fixed by #7011
Assignees
Labels
area/dev Issues or PRs related to `odo dev` kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Milestone

Comments

@kadel
Copy link
Member

kadel commented Jan 12, 2023

/kind bug
/priority medium

How did you run odo exactly?

▶ odo init --name test --devfile nodejs --starter nodejs-starter
  __
 /  \__     Initializing a new component
 \__/  \
 /  \__/    odo version: v3.5.0
 \__/

 ✓  Downloading devfile "nodejs" [2s]
 ✓  Downloading starter project "nodejs-starter" [570ms]

Your new component 'test' is ready in the current directory.
To start editing your component, use 'odo dev' and open this folder in your favorite IDE.
Changes will be directly reflected on the cluster.

▶ odo dev
  __
 /  \__     Developing using the "test" Devfile
 \__/  \    Namespace: tkral-dev
 /  \__/    odo version: v3.5.0
 \__/

↪ Deploying to the cluster in developer mode
 •  Waiting for Kubernetes resources  ...
 ✓  Pod is Running
 ✓  Syncing files into the container [2s]
 ✓  Building your application in container on cluster (command: install) [6s]
 •  Executing the application (command: run)  ...
 -  Forwarding from 127.0.0.1:40002 -> 3000

 -  Forwarding from 127.0.0.1:40003 -> 5858


↪ Dev mode
 Status:
 Watching for changes in the current directory /Users/tkral/Code/odo-examples/tmp

 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster

make changes to server.js

Pushing files...


File /Users/tkral/Code/odo-examples/tmp/server.js changed
 •  Waiting for Kubernetes resources  ...
 ✓  Syncing files into the container [1s]
 ✓  Building your application in container on cluster (command: install) [2s]
 ✗  Finished executing the application (command: run) [1m]
 •  Executing the application (command: run)  ...

↪ Dev mode
 Status:
 Watching for changes in the current directory /Users/tkral/Code/odo-examples/tmp

 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster

line
✗ Finished executing the application (command: run) [1m]
makes it look like something failed

Expected behavior

When it is expected that the run process should end the status message should have the green tick mark

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Jan 12, 2023
@rm3l rm3l added this to odo Project Jan 12, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 12, 2023
@rm3l
Copy link
Member

rm3l commented Jan 23, 2023

Grooming (2023-01-23)

  • Distinguish between a "normal" stop of the application (when we are intentionally restarting it, e.g., due to a change in local files) and an "abnormal" stop (remote command exited, container restarted due to changes in the cluster, ...)
  • Idea to have 3 states in the Spinner (started, finished with error, finished without error)

@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Mar 23, 2023
@github-actions
Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2023
@rm3l
Copy link
Member

rm3l commented Jun 29, 2023

/remove-lifecycle stale
/lifecycle active

Under consideration for the upcoming sprints.

@openshift-ci openshift-ci bot added lifecycle/active Indicates that an issue or PR is actively being worked on. It will not be closed automatically. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 29, 2023
@rm3l rm3l removed the lifecycle/active Indicates that an issue or PR is actively being worked on. It will not be closed automatically. label Jul 24, 2023
@feloy feloy self-assigned this Aug 1, 2023
@feloy feloy moved this to In Progress 🚧 in odo Project Aug 1, 2023
@feloy feloy moved this from In Progress 🚧 to Done ✅ in odo Project Aug 1, 2023
@rm3l rm3l added this to the v3.14.0 🚀 milestone Aug 1, 2023
@feloy feloy moved this from Done ✅ to In Review 👀 in odo Project Aug 1, 2023
@rm3l rm3l added the area/dev Issues or PRs related to `odo dev` label Aug 2, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in odo Project Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev Issues or PRs related to `odo dev` kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants