-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes stopped command terminate normally #7011
Makes stopped command terminate normally #7011
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
7fcc172
to
c980d07
Compare
c980d07
to
709fba1
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/override windows-integration-test/Windows-test
|
@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind bug
What does this PR do / why we need it:
This PR makes a command stopped appear as terminating normally.
This is do by removing the remote pid file before to kill the process.
Which issue(s) this PR fixes:
Fixes #6486
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: