Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On cluster, when run is hotReloadCapable, the Build command is not called after source sync #6695

Closed
3 tasks
Tracked by #6697
feloy opened this issue Mar 28, 2023 · 2 comments · Fixed by #6696
Closed
3 tasks
Tracked by #6697

On cluster, when run is hotReloadCapable, the Build command is not called after source sync #6695

feloy opened this issue Mar 28, 2023 · 2 comments · Fixed by #6696
Assignees
@feloy
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
v3.11.0 🚀

Comments

@feloy
Copy link
Contributor

feloy commented Mar 28, 2023 •
edited by valaparthvi
Loading

/kind bug

On cluster, when Run command is hotReloadCapable, the Build command is not executed after source sync.

On Podman, the Build command is executed after each source sync.

Acceptance Criteria

  • Behavior should be consistent on both podman and cluster; build command should be called after source sync if it is not hotReloadCapable.
  • Document the behavior in how odo dev works.
  • Make sure all tests pass

What versions of software are you using?

odo v3.8.0
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 28, 2023
@feloy feloy mentioned this issue Mar 28, 2023
Closed
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Mar 28, 2023
@feloy feloy mentioned this issue Mar 28, 2023
Merged
3 tasks
@feloy feloy self-assigned this Mar 28, 2023
@rm3l rm3l added this to the v3.9.0 🚀 milestone Mar 29, 2023
@feloy feloy mentioned this issue Mar 29, 2023
Closed
8 tasks
@feloy feloy added the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Mar 29, 2023
@rm3l
Copy link
Member

rm3l commented Apr 4, 2023

Link to PR in devfile/api : devfile/api#1091

@rm3l rm3l modified the milestones: v3.9.0 🚀, v3.10.0 🚀 Apr 5, 2023
@valaparthvi
Copy link
Contributor

Should not be merged before #6747 is closed/validated.

@valaparthvi valaparthvi removed status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. labels May 2, 2023
@rm3l rm3l modified the milestones: v3.10.0 🚀, v3.11.0 🚀 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
odo Project
Archived in project
Milestone
v3.11.0 🚀
Development

Successfully merging a pull request may close this issue.

Fix HotReloadCapable Build command feloy/odo
3 participants
@rm3l @feloy @valaparthvi