Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotReloadCapable support #6697

Closed
8 tasks done
feloy opened this issue Mar 29, 2023 · 3 comments
Closed
8 tasks done

hotReloadCapable support #6697

feloy opened this issue Mar 29, 2023 · 3 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/*` and requires one.

Comments

@feloy
Copy link
Contributor

feloy commented Mar 29, 2023

/kind bug

There exists some misunderstandings around the hotReloadCapable meaning.

On Odo:

  • on cluster: When Run command is hoteloadCapable, Build and Run commands are executed only once
  • on Podman, when Run command is hotReloadCapable, Run command only is executed only once.
  • on both podman and cluster, the hotReloadCapable'ity of the Build command is not considered

On Devfile stacks:

  • on Angular devfile (and similar), the Run command is marked as hotReloadCapable, but not the Build command. This is compatible with the behaviour of odo on cluster, but not on Podman (as the Build command should be executed only once).

After discussion with @tkral, we propose to disambiguate this by:

Related issues:

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Mar 29, 2023
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 29, 2023
@valaparthvi
Copy link
Contributor

valaparthvi commented Apr 5, 2023

Track this issue for the hotReloadCapable support.
Blocked: devfile/api#1091

@valaparthvi valaparthvi added status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) and removed status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) labels Apr 5, 2023
@valaparthvi valaparthvi added needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. and removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. labels Apr 18, 2023
@feloy
Copy link
Contributor Author

feloy commented May 11, 2023

/close

@openshift-ci openshift-ci bot closed this as completed May 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

@feloy: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/*` and requires one.
Projects
Archived in project
Development

No branches or pull requests

2 participants