Fake filesystem changes to devfile parser #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/retest |
1 similar comment
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #2667 +/- ##
==========================================
- Coverage 43.54% 43.51% -0.03%
==========================================
Files 78 81 +3
Lines 7289 7565 +276
==========================================
+ Hits 3174 3292 +118
- Misses 3809 3958 +149
- Partials 306 315 +9
Continue to review full report at Codecov.
|
mik-dass
reviewed
Mar 9, 2020
| @@ -39,8 +40,12 @@ func TestSetDevfileContent(t *testing.T) { | |||
| t.Run("valid file", func(t *testing.T) { | |||
|
|
|||
| var ( | |||
| tempDevfile = createTempDevfile(t, validJsonRawContent100()) | |||
| d = DevfileCtx{absPath: tempDevfile.Name()} | |||
| fakeFs = filesystem.NewFakeFs() | |||
There was a problem hiding this comment.
shouldn't this test be converted to table format?
kanchwala-yusuf
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
lgtm
cdrage
added
the
kind/feature
rm3l
added
estimated-size/L (20-40)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does does this PR do / why we need it:
Accommodating review comments from #2500
Which issue(s) this PR fixes:
Fixes #2553
How to test changes / Special notes to the reviewer:
Devfile related actions should work without any errors.