[Devfile] Remove namespace flag from odo commands #2909

johnmcollier · 2020-04-16T16:49:03Z

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind cleanup
/area devfile

What does does this PR do / why we need it:
As mentioned earlier, we decided to use only the --project flag in odo for devfile components and to not use --namespace at this moment. This PR removes the --namespace flag that was added to certain odo commands for use with devfile components and uses --project instead. For commands that didn't have the --project flag added to it, the flag was added.

Integration tests updated to use --project only as well.

Which issue(s) this PR fixes:

Fixes #2769

How to test changes / Special notes to the reviewer:

Run the unit and integration tests
odo create --project <project> -> Verify namespace/project in env.yaml is correct
odo push --project <project> -> should push to the proper namespace
odo delete --project <project> -> should delete from the proper namespace
odo watch --project <project> -> should push changes to the proper namespace

Signed-off-by: John Collier <John.J.Collier@ibm.com>

johnmcollier · 2020-04-16T23:59:13Z

/retest

More OpenShift CI flakiness

johnmcollier · 2020-04-17T02:24:09Z

/retest

codecov · 2020-04-17T04:47:00Z

Codecov Report

Merging #2909 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2909   +/-   ##
=======================================
  Coverage   44.71%   44.71%           
=======================================
  Files         107      107           
  Lines       10126    10126           
=======================================
  Hits         4528     4528           
  Misses       5162     5162           
  Partials      436      436

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c339c...58c1aa1. Read the comment docs.

kadel · 2020-04-17T08:40:18Z

/approve

openshift-ci-robot · 2020-04-17T08:40:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: John Collier <John.J.Collier@ibm.com>

mik-dass · 2020-04-20T11:52:52Z

pkg/odo/cli/component/push.go

@@ -65,6 +66,13 @@ func (po *PushOptions) Complete(name string, cmd *cobra.Command, args []string)
 		}
 		po.EnvSpecificInfo = envinfo
 		po.Context = genericclioptions.NewDevfileContext(cmd)
+
+		if cmd.Flags().Changed("project") {


I think this needs to be moved here https://github.com/openshift/odo/blob/6740e5177ae11db734f7d3d303c4f689015e3b91/pkg/odo/genericclioptions/context.go#L343. We are repeating the same steps in all the above files.

@mik-dass You're right, good catch!

Actually, we don't need to move any code to resolveNamespace, just update it to retrieve the namespace from the --project flag.

So long as we initialize the devfile context in each command that needs it, we can retrieve the namespace via kclient.Namespace

Signed-off-by: John Collier <John.J.Collier@ibm.com>

johnmcollier · 2020-04-21T04:05:18Z

/retest

johnmcollier · 2020-04-21T13:30:23Z

/retest

Signed-off-by: John Collier <John.J.Collier@ibm.com>

johnmcollier · 2020-04-21T19:24:02Z

/retest

johnmcollier · 2020-04-22T02:43:30Z

More CI infra flakes 😢

/retest

Signed-off-by: John Collier <John.J.Collier@ibm.com>

johnmcollier · 2020-04-24T20:11:52Z

/retest

Giving the builds a kick due to the gosec issues earlier

johnmcollier · 2020-04-25T00:36:10Z

/retest

johnmcollier · 2020-04-27T14:48:23Z

/retest

johnmcollier · 2020-04-27T14:49:06Z

@mik-dass I've rebased and addressed your review comment (retrieving namespace from the getNamespace function)

mik-dass

/lgtm

openshift-bot · 2020-04-27T16:34:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-27T16:47:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-27T17:00:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

johnmcollier · 2020-04-27T18:48:09Z

There may be a potential merge conflict with this and #2922, so I'm holding this so that it doesn't slip in to this afternoon's release and delay 2922. I'll cancel the hold after the release.

/hold

Signed-off-by: John Collier <John.J.Collier@ibm.com>

johnmcollier · 2020-04-27T20:58:00Z

/hold cancel

maysunfaisal · 2020-04-27T21:09:11Z

tests were updated! Thx
re-adding lgtm
/lgtm

openshift-bot · 2020-04-27T23:04:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-28T01:01:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-28T01:14:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-28T01:40:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-28T02:58:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-28T03:11:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

johnmcollier added 4 commits April 14, 2020 21:11

Remove namespace flags

1bf57cc

Signed-off-by: John Collier <John.J.Collier@ibm.com>

Update integration tests to use --project

d434c5d

Signed-off-by: John Collier <John.J.Collier@ibm.com>

Merge branch 'master' of github.com:openshift/odo into removenamespace

d68b1bf

Signed-off-by: John Collier <John.J.Collier@ibm.com>

Check if namespace equals empty string

f324134

Signed-off-by: John Collier <John.J.Collier@ibm.com>

openshift-ci-robot added kind/cleanup area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Apr 16, 2020

openshift-ci-robot requested review from cdrage and mohammedzee1000 April 16, 2020 16:49

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels Apr 17, 2020

Merge branch 'master' of github.com:openshift/odo into removenamespace

1386a8f

Signed-off-by: John Collier <John.J.Collier@ibm.com>

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 17, 2020

mik-dass reviewed Apr 20, 2020

View reviewed changes

GeekArthur mentioned this pull request Apr 20, 2020

devfile odo push failed to start component on kubernetes cluster #2928

Closed

johnmcollier added 3 commits April 20, 2020 17:58

Retrieve namespace via context

3230307

Signed-off-by: John Collier <John.J.Collier@ibm.com>

Fix glitched package import

a475117

Signed-off-by: John Collier <John.J.Collier@ibm.com>

Remove dead code

856497a

Signed-off-by: John Collier <John.J.Collier@ibm.com>

johnmcollier added 4 commits April 21, 2020 09:33

Merge branch 'master' of github.com:openshift/odo into removenamespace

0969fac

Fix watch test

cd0d701

Signed-off-by: John Collier <John.J.Collier@ibm.com>

Fix flaky test due to unimplemented context flag

f8955f1

Signed-off-by: John Collier <John.J.Collier@ibm.com>

Remove duplicated devfile test

7e2d858

Signed-off-by: John Collier <John.J.Collier@ibm.com>

Update tests

6748b3c

Signed-off-by: John Collier <John.J.Collier@ibm.com>

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 24, 2020

mik-dass approved these changes Apr 27, 2020

View reviewed changes

openshift-ci-robot assigned mik-dass Apr 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 27, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 27, 2020

Merge branch 'master' of github.com:openshift/odo into removenamespace

fb590d7

Signed-off-by: John Collier <John.J.Collier@ibm.com>

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 27, 2020

Use project flag

58c1aa1

Signed-off-by: John Collier <John.J.Collier@ibm.com>

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 27, 2020

openshift-ci-robot assigned maysunfaisal Apr 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 27, 2020

openshift-merge-robot merged commit f81ca6b into redhat-developer:master Apr 28, 2020

rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Devfile] Remove namespace flag from odo commands #2909

[Devfile] Remove namespace flag from odo commands #2909

johnmcollier commented Apr 16, 2020 •

edited

Loading

johnmcollier commented Apr 16, 2020

johnmcollier commented Apr 17, 2020

codecov bot commented Apr 17, 2020 •

edited

Loading

kadel commented Apr 17, 2020

openshift-ci-robot commented Apr 17, 2020

mik-dass Apr 20, 2020

johnmcollier Apr 20, 2020

johnmcollier Apr 20, 2020

johnmcollier commented Apr 21, 2020

johnmcollier commented Apr 21, 2020

johnmcollier commented Apr 21, 2020

johnmcollier commented Apr 22, 2020

johnmcollier commented Apr 24, 2020

johnmcollier commented Apr 25, 2020

johnmcollier commented Apr 27, 2020

johnmcollier commented Apr 27, 2020

mik-dass left a comment

openshift-bot commented Apr 27, 2020

openshift-bot commented Apr 27, 2020

openshift-bot commented Apr 27, 2020

johnmcollier commented Apr 27, 2020

johnmcollier commented Apr 27, 2020

maysunfaisal commented Apr 27, 2020 •

edited

Loading

openshift-bot commented Apr 27, 2020

openshift-bot commented Apr 28, 2020

openshift-bot commented Apr 28, 2020

openshift-bot commented Apr 28, 2020

openshift-bot commented Apr 28, 2020

openshift-bot commented Apr 28, 2020

[Devfile] Remove namespace flag from odo commands #2909

[Devfile] Remove namespace flag from odo commands #2909

Conversation

johnmcollier commented Apr 16, 2020 • edited Loading

johnmcollier commented Apr 16, 2020

johnmcollier commented Apr 17, 2020

codecov bot commented Apr 17, 2020 • edited Loading

Codecov Report

kadel commented Apr 17, 2020

openshift-ci-robot commented Apr 17, 2020

mik-dass Apr 20, 2020

Choose a reason for hiding this comment

johnmcollier Apr 20, 2020

Choose a reason for hiding this comment

johnmcollier Apr 20, 2020

Choose a reason for hiding this comment

johnmcollier commented Apr 21, 2020

johnmcollier commented Apr 21, 2020

johnmcollier commented Apr 21, 2020

johnmcollier commented Apr 22, 2020

johnmcollier commented Apr 24, 2020

johnmcollier commented Apr 25, 2020

johnmcollier commented Apr 27, 2020

johnmcollier commented Apr 27, 2020

mik-dass left a comment

Choose a reason for hiding this comment

openshift-bot commented Apr 27, 2020

openshift-bot commented Apr 27, 2020

openshift-bot commented Apr 27, 2020

johnmcollier commented Apr 27, 2020

johnmcollier commented Apr 27, 2020

maysunfaisal commented Apr 27, 2020 • edited Loading

openshift-bot commented Apr 27, 2020

openshift-bot commented Apr 28, 2020

openshift-bot commented Apr 28, 2020

openshift-bot commented Apr 28, 2020

openshift-bot commented Apr 28, 2020

openshift-bot commented Apr 28, 2020

johnmcollier commented Apr 16, 2020 •

edited

Loading

codecov bot commented Apr 17, 2020 •

edited

Loading

maysunfaisal commented Apr 27, 2020 •

edited

Loading