Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the minikube version on travis CI #3109

Merged
merged 2 commits into from
May 7, 2020
Merged

Upgrade the minikube version on travis CI #3109

merged 2 commits into from
May 7, 2020

Conversation

prietyc123
Copy link
Contributor

@prietyc123 prietyc123 commented May 6, 2020 •
edited
Loading

What type of PR is this?

/kind feature

What does does this PR do / why we need it:

odo push is supported only on minikube version 0.25+ . So upgrading minikube version on travis CI

Which issue(s) this PR fixes:

Fixes #2928
Fixes #3055

How to test changes / Special notes to the reviewer:
devfile integration test should run on upgraded version of minikube.

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label May 6, 2020
@prietyc123 prietyc123 force-pushed the UpgradeMinikubeVersion branch from 6ec87cf to bcf3e79 Compare May 6, 2020 15:31
@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 6, 2020
@kadel
Copy link
Member

kadel commented May 6, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 6, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@kadel
Copy link
Member

kadel commented May 6, 2020

/hold
waiting for travis to pass

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label May 6, 2020
@prietyc123
Copy link
Contributor Author

/hold
waiting for travis to pass

Travis passed.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label May 6, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@codecov
Copy link

codecov bot commented May 6, 2020 •
edited
Loading

Codecov Report

Merging #3109 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3109      +/-   ##
==========================================
- Coverage   45.43%   45.39%   -0.04%     
==========================================
  Files         109      109              
  Lines       10400    10400              
==========================================
- Hits         4725     4721       -4     
- Misses       5220     5222       +2     
- Partials      455      457       +2
Impacted Files Coverage Δ
pkg/sync/sync.go 45.54% <0.00%> (-3.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1232ad...bcf3e79. Read the comment docs.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b26a1f5 into redhat-developer:master May 7, 2020
@prietyc123 prietyc123 mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit Awaiting requested review from dharmit

@mik-dass mik-dass Awaiting requested review from mik-dass

Assignees

@amitkrout amitkrout

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
6 participants
@prietyc123 @amitkrout @kadel @openshift-ci-robot @openshift-bot @openshift-merge-robot