-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devfile URL create flake fix #3125
Devfile URL create flake fix #3125
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -53,7 +54,7 @@ var _ = Describe("odo devfile url command tests", func() { | |||
helper.CmdShouldPass("git", "clone", "https://github.com/che-samples/web-nodejs-sample.git", projectDirPath) | |||
helper.Chdir(projectDirPath) | |||
|
|||
helper.CmdShouldPass("odo", "create", "nodejs", "--project", namespace, componentName) | |||
helper.CmdShouldPass("odo", "create", "nodejs", componentName, "--project", namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is nothing to deal with the flake fix. I just put the component name adjacent to componentType to make whole command more sync with our UX examples.
Thanks bot for reporting it quickly. Otherwise it is very pain full if same error would have been reported after 30 min...hahahaha.... |
/test v4.2-integration-e2e |
d69c0a3
to
8e99c8e
Compare
The test still failed with this PR: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/3125/pull-ci-openshift-odo-master-v4.4-integration-e2e/207 The test failed is because when creating url using |
To avoid conflict in parallel run we are using context dir while creating the component or from inside the context dir we are launching the component create along with the flag
This is how the regular odo url create command works. May be i am missing something in case of experimental mode for devfile. @yangcao77 Please share you thoughts. Thanks |
8e99c8e
to
e6e605b
Compare
e6e605b
to
c674321
Compare
@amitkrout: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test v4.3-integration-e2e |
Closing as per #3122 (comment). The fix lies somewhere else. |
@amitkrout I links this PR in comment: #3122 (comment) |
What type of PR is this?
/kind flake
What does does this PR do / why we need it:
Fixing of flakes like
in devfile url test
Which issue(s) this PR fixes:
https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/8707/rehearse-8707-periodic-ci-openshift-odo-master-v4.3-integration-e2e-periodic/6#1:build-log.txt%3A423
How to test changes / Special notes to the reviewer:
CI should not fails at - https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/8707/rehearse-8707-periodic-ci-openshift-odo-master-v4.3-integration-e2e-periodic/6#1:build-log.txt%3A423