Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run integration e2e test on mac and windows #3143

Conversation

amitkrout
Copy link
Contributor

What type of PR is this?
/kind feature

What does does this PR do / why we need it:
Integration and e2e test coverage on mac and windows
Which issue(s) this PR fixes:

Fixes #2540

How to test changes / Special notes to the reviewer:
Integration and e2e test should run on windows and mac setup in travis CI

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label May 11, 2020
@amitkrout amitkrout changed the title Run integration e2e test on mac and windows [WIP] Run integration e2e test on mac and windows May 11, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 11, 2020
@amitkrout amitkrout force-pushed the runIntegrationE2eTestOnMacAndWindows branch from 7b001a5 to b4b1cd3 Compare May 11, 2020 12:29
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #3143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3143   +/-   ##
=======================================
  Coverage   44.93%   44.93%           
=======================================
  Files         133      133           
  Lines       12749    12749           
=======================================
  Hits         5729     5729           
  Misses       6460     6460           
  Partials      560      560           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd05017...929fbf4. Read the comment docs.

@amitkrout amitkrout force-pushed the runIntegrationE2eTestOnMacAndWindows branch from b4b1cd3 to 103aafb Compare May 29, 2020 08:44
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign amitkrout
You can assign the PR to them by writing /assign @amitkrout in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amitkrout amitkrout force-pushed the runIntegrationE2eTestOnMacAndWindows branch 5 times, most recently from ff68e71 to e748d4d Compare May 29, 2020 11:14
@mohammedzee1000
Copy link
Contributor

mohammedzee1000 commented Jun 1, 2020

It appears that the environment variables PULL_SECRET_PATH and JOB_SPECare coming out empty. going to @openshift/openshift-team-developer-productivity-test-platform

@amitkrout
Copy link
Contributor Author

amitkrout commented Jun 1, 2020

Blocked due to #3270

more details - #2540 (comment)

@amitkrout amitkrout added status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels Jul 1, 2020
@amitkrout amitkrout changed the title [WIP] Run integration e2e test on mac and windows Run integration e2e test on mac and windows Jul 1, 2020
@girishramnani
Copy link
Contributor

@amitkrout this needs rebase, assuming the template based workflow now just has some flaky errors - can we move forward on this?

@mik-dass mik-dass added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 14, 2020
@girishramnani
Copy link
Contributor

Any update on this?

@amitkrout amitkrout removed the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Jul 24, 2020
@amitkrout
Copy link
Contributor Author

Any update on this?

Now i am unblocked via openshift/release#9431.

@amitkrout amitkrout force-pushed the runIntegrationE2eTestOnMacAndWindows branch from e748d4d to 36735d2 Compare July 27, 2020 06:52
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 27, 2020
@amitkrout amitkrout force-pushed the runIntegrationE2eTestOnMacAndWindows branch from 36735d2 to 63896d1 Compare August 9, 2020 06:34
@amitkrout amitkrout force-pushed the runIntegrationE2eTestOnMacAndWindows branch from 63896d1 to 929fbf4 Compare August 10, 2020 10:42
@cdrage
Copy link
Member

cdrage commented Aug 17, 2020

Any updates @amitkrout ? I'm ready to review this but unsure on the status.

@amitkrout
Copy link
Contributor Author

amitkrout commented Aug 20, 2020

Any updates @amitkrout ? I'm ready to review this but unsure on the status.

This pr will be done by phases so that it won't break our master. I have already role out couple of prs for travis cli installation and prow job creation.

The steps are

@amitkrout
Copy link
Contributor Author

Not for sprint 189
/close

@amitkrout amitkrout closed this Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run e2e and integration test on windows and macOS host
6 participants