[WIP] Added basic PostStart functionality #3283
Conversation
* Add Devfile Parser for Version 2.0.0 Added Devfile V2 Go Structures Added converter for v2 ro common types Signed-off-by: adisky <adsharma@redhat.com> * Add example V2 devfile added example nodejs V2 devfile * Add Common Types as V2 Add common types as v2 Add Converter from common to v1 * Updated example devfile with group
Signed-off-by: mik-dass <mrinald7@gmail.com>
Signed-off-by: mik-dass <mrinald7@gmail.com>
…3206) * Update Docker and Kubernetes adapter to use groups * Update Some Validation Incorporate some review comments for commands Map Update Some Validation logic
Fixed interface implementation for v2 Updated logs refactored commands.go
While converting v1 to v2 types, string pointers are prone to cause null pointer error. This PR updates struct fields from string pointers to string
* Update command tests Updated Command tests to v2 Removed some cases like command type validation, that will be validated by schema only. * Fix common adapters tests All devfile.adapters.common unit tests are fixed * Add tests for Mismatched type Fix devfile.adapters.Kubernetes.Component unit tests * Add TestCase for default command
… status for IDE integration for devfile scenarios (redhat-developer#2550) (redhat-developer#3177) * Add event notification proposal [skip ci] * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md
* Fix Integration tests Correct volume structure Fix supervisord binary insertion for docker Insert command and args in build container fr docker * Fix Integration tests Revert commands, args removal Add commands, args in v2 common structs Fix duplicate volume error
Signed-off-by: mik-dass <mrinald7@gmail.com>
Add devfiles v2 examples for springboot and nodejs
fix regression caused by rebase to master. Also add github, zip as supported project types.
fix log levels to v4 fix error formatting add case no's in test cases update some comments
Remove validation for group
openshift-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @upLukeWeston. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I'm afraid that it is too early for this PR. |
|
Sure, no problem! I'll close this PR then and we can continue the discussion on the issue. |
What type of PR is this?
/kind feature
What does does this PR do / why we need it:
Adds the basic functionality for PostStart commands to be executed when a container is first created.
Which issue(s) this PR fixes:
Fixes #2936
How to test changes / Special notes to the reviewer:
Blocked by #3216