-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy Command for OCP #3478
Closed
Closed
Deploy Command for OCP #3478
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
90191a4
WIP: Add simple poc build command
EnriqueL8 efab329
POC Build
EnriqueL8 ddf14ab
WIP: Add syncfiles poc for build
EnriqueL8 037012d
Add ServiceAccount env
EnriqueL8 78f28ae
Clean up code
EnriqueL8 ea4a573
Add defer for delete
EnriqueL8 11dec2b
First pass downloading Dockerfile specified in devfile
upLukeWeston 2bc2e4c
Merge branch 'deploy_command' of https://github.com/EnriqueL8/odo int…
upLukeWeston 630ae4a
Fix compilation issue
EnriqueL8 4102af3
Moved Dockerfile download to .odo to avoid overwriting users one in t…
upLukeWeston 630b9dd
Merge branch 'deploy_command' into parse_dockerfile
upLukeWeston a81f13f
Updates for initial deploy steps
groeges 603b722
Tidy up following PR comments
groeges 8733e06
Incorporate changes to determine manifest from devfile.yaml
groeges 500000b
Updates for initial deploy steps
EnriqueL8 0041f07
Fixing seg fault and defer error
EnriqueL8 958932d
User validation and Dockerfile in memory support
upLukeWeston 12658f2
Add delete deploy (#7)
EnriqueL8 7129292
Include additional parts of deploy manifest step (#4)
groeges 1e2c221
Build config (#8)
EnriqueL8 1d1423b
updated manifest file and added tests (#10)
32beaf9
Resolve PR comments and change to use alpha.build-dockerfile and (#11)
groeges fe7dbaa
Add some tests for manifest deploy part of `odo deploy` command (#13)
groeges 4f53442
Remove --deployOnly option (#14)
groeges 1008511
General clean up (#12)
EnriqueL8 9d82133
Merge remote-tracking branch 'origin/master' into deploy_command
EnriqueL8 3cc73db
Fix issues in merge conflict
EnriqueL8 8291abb
Fix tests following restructure of command messages (#16)
groeges 431717c
Fix issues in merge conflict
EnriqueL8 6790683
Fix dockerfile test
EnriqueL8 69a3c58
Reduced permissions on file created (#15)
upLukeWeston 586caaa
Fix deploy delete tests
EnriqueL8 84cc342
Delete duplicate line in test
EnriqueL8 2f548b7
Removing warning check in test
EnriqueL8 bb21b19
Remove output variable from test
EnriqueL8 511a0a4
Allow use of file:// in devfile.yaml for manifest and dockerfile (#20)
groeges 58ac5b7
Handle CTRL-C during Build (#19)
upLukeWeston 1ae5ece
Add check for valid URL/PORT in env.yaml if PORT defined in manifest …
groeges 9d9cb93
Add tag format to flag help text.
EnriqueL8 c99828e
Update method of determining the application URL (#18)
groeges f4630b1
Update to use text/template for template variable substitution (#23)
groeges 266151b
Update error message for test
EnriqueL8 d0913d9
Requested Changes
EnriqueL8 d857988
Merge remote-tracking branch 'origin/master' into deploy_command
EnriqueL8 0c88e9d
Fix issues with merge conflicts
EnriqueL8 febd952
Update devfile schema (#24)
groeges 33379af
Support odo deploy without tag (#22)
upLukeWeston 32d6fff
Add missing packages (#25)
groeges 7ffd1bd
Merge remote-tracking branch 'origin/master' into deploy_command
EnriqueL8 150c6ab
Add deploy tests to travis
EnriqueL8 554045c
Change url log to warning
EnriqueL8 6e4e53a
Fix issues with deploy tests which check for imagestreams (#26)
groeges b584397
Fix linting errors (#27)
EnriqueL8 89d7531
Merge branch 'master' into deploy_command
EnriqueL8 b3c3a36
Fix merge conflict formating
EnriqueL8 defd971
Merge branch 'master' into deploy_command
EnriqueL8 5c4c196
Fix fmt merge conflicts
EnriqueL8 164e921
Trying svc.cluster.local as registry url
EnriqueL8 db0f4c9
Dynamically get registry URL
EnriqueL8 9c30cbc
Merge remote-tracking branch 'origin/master' into deploy_command
EnriqueL8 bfbb7dd
Fix DeployParameters Comment
EnriqueL8 ca0dd6c
Merge remote-tracking branch 'origin/master' into deploy_command
EnriqueL8 51a5d36
Fix linting errors
EnriqueL8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK we are already running the whole devfile target under https://github.com/openshift/odo/blob/master/Makefile#L374-L377, its just duplicating the jobs.