Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing kubeconfig path and login session for 4.x cluster #3528

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Fixing kubeconfig path and login session for 4.x cluster #3528

merged 1 commit into from
Jul 11, 2020

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?

/kind bug
/kind cleanup
/kind feature

What does does this PR do / why we need it:

Configuring kubeconfig path and login session for test script running against 4.x cluster

Which issue(s) this PR fixes:

Fixes #3501

How to test changes / Special notes to the reviewer:

Test script should use the developer login session and pr openshift/release#9431 should not fail.

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Jul 9, 2020
@prietyc123 prietyc123 requested a review from amitkrout July 9, 2020 08:37
@prietyc123
Copy link
Contributor Author

prietyc123 commented Jul 9, 2020 •
edited
Loading

ping @amitkrout

Thanks for your input 🙂

@prietyc123
Copy link
Contributor Author

https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/3528/pull-ci-openshift-odo-master-v4.3-integration-e2e/1281145237829324800#1:build-log.txt%3A496

/retest

amitkrout
amitkrout reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@amitkrout amitkrout left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

++ mktemp -d
+ TMP_DIR=/tmp/tmp.7tuJJ0OiAJ
+ cp /tmp/admin.kubeconfig /tmp/tmp.7tuJJ0OiAJ/kubeconfig
+ chmod 640 /tmp/tmp.7tuJJ0OiAJ/kubeconfig
+ export KUBECONFIG=/tmp/tmp.7tuJJ0OiAJ/kubeconfig
+ KUBECONFIG=/tmp/tmp.7tuJJ0OiAJ/kubeconfig
+ odo login -u developer -p developer
Connecting to the OpenShift cluster

Login successful.

You have access to the following projects and can switch between them with 'odo project set <project-name>':

  * ci-operator-hub-project
    myproject

Using project "ci-operator-hub-project".
+ oc whoami
developer
+ make test-integration
ginkgo  -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=2 tests/integration/
Running Suite: Integration Suite
================================

looks good to me.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 9, 2020
@girishramnani
Copy link
Contributor

Trusting @amitkrout’s judgement on this

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 9, 2020
kadel
kadel reviewed Jul 9, 2020
View reviewed changes
scripts/configure-installer-tests-cluster.sh

# KUBECONFIG cleanup only if CI is set
if [ ! -f $CI ]; then
rm -rf $KUBECONFIG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the kubeconfig should happen in the file where it was created (in the test scripts)

Copy link
Contributor Author

@prietyc123 prietyc123 Jul 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the kubeconfig should happen in the file where it was created (in the test scripts)

This kubeconfig will not get used in the test script reason #3501 (comment) . So rather than keeping two kubeconfig, one in configure-installer-tests-cluster.sh other with the tests. I am just deleting it at the end.

@codecov
Copy link

codecov bot commented Jul 9, 2020 •
edited
Loading

Codecov Report

Merging #3528 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3528   +/-   ##
=======================================
  Coverage   46.18%   46.18%           
=======================================
  Files         112      112           
  Lines       11333    11333           
=======================================
  Hits         5234     5234           
  Misses       5593     5593           
  Partials      506      506

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ffe36...e633aa6. Read the comment docs.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@prietyc123 prietyc123 force-pushed the FixingKubeconfigPathAndLoginSession branch from 80c2b14 to e633aa6 Compare July 10, 2020 13:07
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 10, 2020
@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 11, 2020
@amitkrout
Copy link
Contributor

/refresh

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8791263 into redhat-developer:master Jul 11, 2020
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel left review comments

@amitkrout amitkrout amitkrout left review comments

@cdrage cdrage Awaiting requested review from cdrage

@girishramnani girishramnani Awaiting requested review from girishramnani

Assignees

@amitkrout amitkrout

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KUBECONFIG somehow reverted back to the original path in CI
8 participants
@prietyc123 @girishramnani @openshift-ci-robot @openshift-bot @amitkrout @kadel @rm3l @openshift-merge-robot