Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove requirement for URL to end with .zip #3854

Merged
merged 1 commit into from
Aug 28, 2020
Merged

fix: remove requirement for URL to end with .zip #3854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,9 +904,6 @@ func GetAndExtractZip(zipURL string, destination string, pathToUnzip string) err
if zipURL == "" {
return errors.Errorf("Empty zip url: %s", zipURL)
}
if !strings.Contains(zipURL, ".zip") {
return errors.Errorf("Invalid zip url: %s", zipURL)
}

var pathToZip string
if strings.HasPrefix(zipURL, "file://") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this PR but do we want to also enforce that the url starts with file:// a url could be a simple http or https one but could have a zip file returned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the rest of the code which deals with that… 😉

Expand Down