Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental mode from docs #3855

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Aug 27, 2020

What type of PR is this?
/kind documentation
[skip ci]

What does does this PR do / why we need it:

There are outdated portions of our documentation that asks for you to
enable experimental mode before using Devfile or Operator Hub.

Both of those have moved out of experimental mode.

Since our website (https://odo.dev) reflects using the alpha release,
we must update the outdated documentation.

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

**What type of PR is this?**
/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

There are outdated portions of our documentation that asks for you to
enable experimental mode before using Devfile or Operator Hub.

Both of those have moved out of experimental mode.

Since our website (https://odo.dev) reflects using the `alpha` release,
we must update the outdated documentation.

**Which issue(s) this PR fixes**:

N/A

**PR acceptance criteria**:

- [X] Unit test

- [X] Integration test

- [X] Documentation

- [X] I have read the [test guidelines](https://github.com/openshift/odo/blob/master/docs/dev/test-architecture.adoc)

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@girishramnani
Copy link
Contributor

The experimental mode in my opinion shouldn't be removed from the docs rather we should have a table which shows all the features that are in experimental mode which would soon include the odo deploy

@openshift-ci-robot
Copy link
Collaborator

@cdrage: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.5-integration-e2e 0b3da0d link /test v4.5-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kadel
Copy link
Member

kadel commented Aug 28, 2020

The experimental mode in my opinion shouldn't be removed from the docs rather we should have a table which shows all the features that are in experimental mode which would soon include the odo deploy

That could be added back as part of odo deploy documentation

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 28, 2020
@cdrage
Copy link
Member Author

cdrage commented Aug 28, 2020

The experimental mode in my opinion shouldn't be removed from the docs rather we should have a table which shows all the features that are in experimental mode which would soon include the odo deploy

I agree however the only experimental feature we have in the alpha branch is deploying to Docker. So it'd make sense to remove the experimental notes (for now).

@cdrage
Copy link
Member Author

cdrage commented Aug 31, 2020

Going to merge for now / we can update the docs after

@cdrage cdrage merged commit 14169ab into redhat-developer:master Aug 31, 2020
@cdrage cdrage deleted the remove-experimental-notes branch January 14, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants