-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental mode from docs #3855
Remove experimental mode from docs #3855
Conversation
**What type of PR is this?** /kind documentation [skip ci] **What does does this PR do / why we need it**: There are outdated portions of our documentation that asks for you to enable experimental mode before using Devfile or Operator Hub. Both of those have moved out of experimental mode. Since our website (https://odo.dev) reflects using the `alpha` release, we must update the outdated documentation. **Which issue(s) this PR fixes**: N/A **PR acceptance criteria**: - [X] Unit test - [X] Integration test - [X] Documentation - [X] I have read the [test guidelines](https://github.com/openshift/odo/blob/master/docs/dev/test-architecture.adoc) **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com>
The experimental mode in my opinion shouldn't be removed from the docs rather we should have a table which shows all the features that are in experimental mode which would soon include the |
@cdrage: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
That could be added back as part of /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I agree however the only experimental feature we have in the alpha branch is deploying to Docker. So it'd make sense to remove the experimental notes (for now). |
Going to merge for now / we can update the docs after |
What type of PR is this?
/kind documentation
[skip ci]
What does does this PR do / why we need it:
There are outdated portions of our documentation that asks for you to
enable experimental mode before using Devfile or Operator Hub.
Both of those have moved out of experimental mode.
Since our website (https://odo.dev) reflects using the
alpha
release,we must update the outdated documentation.
Which issue(s) this PR fixes:
N/A
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
N/A
Signed-off-by: Charlie Drage charlie@charliedrage.com