Update the help usage for odo create and odo url create #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind cleanup /kind documentation **What does does this PR do / why we need it**: Updates the `--help` in the following way: - Changes the `odo create --help` usage to a 1-sentence summary similar to every other command - Updates our documentation to remove any mention of crc for something more neutral (example.com) similar to kubectl / kubernetes documentation, for example: https://kubernetes.io/docs/concepts/services-networking/ingress/ **Which issue(s) this PR fixes**: Fixes redhat-developer#3463 **PR acceptance criteria**: - [X] Documentation - [X] I have read the [test guidelines](https://github.com/openshift/odo/blob/master/docs/dev/test-architecture.adoc) **How to test changes / Special notes to the reviewer**: `odo create --help` and `odo url create --help` Signed-off-by: Charlie Drage <charlie@charliedrage.com>
|
/retest |
openshift-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Codecov Report
@@ Coverage Diff @@
## master #3858 +/- ##
==========================================
- Coverage 44.29% 44.19% -0.11%
==========================================
Files 139 141 +2
Lines 13401 13600 +199
==========================================
+ Hits 5936 6010 +74
- Misses 6883 7007 +124
- Partials 582 583 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind documentation
What does does this PR do / why we need it:
Updates the
--helpin the following way:odo create --helpusage to a 1-sentence summary similarto every other command
more neutral (example.com) similar to kubectl / kubernetes
documentation, for example: https://kubernetes.io/docs/concepts/services-networking/ingress/
Which issue(s) this PR fixes:
Fixes #3463
PR acceptance criteria:
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
odo create --helpand
odo url create --helpSigned-off-by: Charlie Drage charlie@charliedrage.com