Remove specifying a component when deleting #3998
Conversation
**What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind bug **What does does this PR do / why we need it**: This is a temporary fix by removing the current feature of being able to pass in a component name to `odo delete`. For example. `odo delete foobar` does not work. We remove that functionality so you may only specify `odo delete` in the current directory. **Which issue(s) this PR fixes**: Does not fix any issues, but please see: redhat-developer#3892 **PR acceptance criteria**: - [X] Unit test - [X] Integration test - [X] Documentation - [X] I have read the [test guidelines](https://github.com/openshift/odo/blob/master/docs/dev/test-architecture.adoc) **How to test changes / Special notes to the reviewer**: ```sh odo create nodejs --starter odo push odo delete ``` Signed-off-by: Charlie Drage <charlie@charliedrage.com>
openshift-ci-robot
added
the
kind/bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cdrage: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| Short: "Delete component", | ||
| Long: "Delete component.", | ||
| Example: fmt.Sprintf(deleteExample, fullName), | ||
| Args: cobra.MaximumNArgs(1), | ||
| Args: cobra.MaximumNArgs(0), |
There was a problem hiding this comment.
Should we still allow a name to be passed in when --s2i is used? Or no, to keep it consistent?
|
Closing for now. We should check this post-release as to not break any compatibility with current s2i components. |
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
This is a temporary fix by removing the current feature of being able to
pass in a component name to
odo delete.For example.
odo delete foobardoes not work. We remove thatfunctionality so you may only specify
odo deletein the currentdirectory.
Which issue(s) this PR fixes:
Does not fix any issues, but please see: #3892
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
Signed-off-by: Charlie Drage charlie@charliedrage.com