-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors storage List() to use Storage Client. #4395
Refactors storage List() to use Storage Client. #4395
Conversation
aff5ff1
to
b61d3fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit, mik-dass The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Unit test flake |
b61d3fd
to
0f55a1b
Compare
Was this force push #4395 (comment) done for the rebase purpose? Asking because it's a large PR and I don't know if I need to re-review something. 😄 |
Yes, it was done for rebase purpose. |
/retest |
…Cluster() to get storage from the cluster.
0f55a1b
to
38fdb95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…Cluster() to get storage from the cluster. (redhat-developer#4395)
What type of PR is this?
/kind code-refactoring
What does does this PR do / why we need it:
Refactors storage List() to use Storage Client. It also adds ListFromCluster() to get storage from the cluster.
Which issue(s) this PR fixes:
Fixes part of #4298
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: