Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply workaround for firewall not taking parameters #4531

Closed
wants to merge 28 commits into from
Closed

Apply workaround for firewall not taking parameters #4531

wants to merge 28 commits into from

Conversation

rnapoles-rh
Copy link
Contributor

What type of PR is this?
/kind bug

What does does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #4288

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Self dependency, Tests should be triggered properly to run both on minikube and minishift

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels Mar 18, 2021
@openshift-ci-robot
Copy link
Collaborator

@rnapoles-rh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rnapoles-rh
To complete the pull request process, please assign prietyc123 after the PR has been reviewed.
You can assign the PR to them by writing /assign @prietyc123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2021

@rnapoles-rh: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.7-integration-e2e 7a8c45b link /test v4.7-integration-e2e
ci/prow/psi-kubernetes-integration-e2e 7a8c45b link /test psi-kubernetes-integration-e2e
ci/prow/psi-minishift-integration-e2e 7a8c45b link /test psi-minishift-integration-e2e
ci/prow/psi-openshift-integration-e2e 7a8c45b link /test psi-openshift-integration-e2e
ci/prow/unit 7a8c45b link /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rnapoles-rh
Copy link
Contributor Author

#4530 takes care of the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use PSI for running OpenShift 3.x tests
2 participants