Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes travis & codecov configuration #4628

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Removes travis & codecov configuration #4628

merged 1 commit into from
Apr 16, 2021

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Apr 16, 2021

What type of PR is this?
/kind cleanup

What does this PR do / why we need it:
odo doesn't use travis any more.

Which issue(s) this PR fixes:

Fixes: None

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Test should pass.

odo doesn't use travis or codecov any more.
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 16, 2021
Copy link
Contributor

@anandrkskd anandrkskd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prietyc123
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 16, 2021
@dharmit
Copy link
Member Author

dharmit commented Apr 16, 2021

@prietyc123 is the failure related to your proposed fix in #4630? Because it seems unrelated to code change in this PR:

 INFO[2021-04-16T07:18:21Z] • Failure [246.176 seconds]     
INFO[2021-04-16T07:18:21Z] odo supported images e2e tests               
INFO[2021-04-16T07:18:21Z] /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:17 
INFO[2021-04-16T07:18:21Z]   odo supported private registry images deployment 
INFO[2021-04-16T07:18:21Z]   /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:125 
INFO[2021-04-16T07:18:21Z]     Should be able to verify the openjdk-11-rhel8 image [It] 
INFO[2021-04-16T07:18:21Z]     /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:133 
INFO[2021-04-16T07:18:21Z]                                              
INFO[2021-04-16T07:18:21Z]     No future change is possible.  Bailing out early after 240.909s. 
INFO[2021-04-16T07:18:21Z]     Running odo with args [odo push --context /tmp/843824974] 
INFO[2021-04-16T07:18:21Z]     Expected                                 
INFO[2021-04-16T07:18:21Z]         <int>: 1                             
INFO[2021-04-16T07:18:21Z]     to match exit code:                      
INFO[2021-04-16T07:18:21Z]         <int>: 0                         
INFO[2021-04-16T07:18:21Z]                                              
INFO[2021-04-16T07:18:21Z]     /go/src/github.com/openshift/odo/tests/helper/helper_run.go:34 
 INFO[2021-04-16T07:18:21Z] [odo] See below for a list of failed events that occured more than 5 times during deployment: 
INFO[2021-04-16T07:18:21Z] [odo]                                        
INFO[2021-04-16T07:18:21Z] [odo]  NAME                                      COUNT  REASON  MESSAGE                  
INFO[2021-04-16T07:18:21Z] [odo]                                        
INFO[2021-04-16T07:18:21Z] [odo]  openjdk-app-app-1-d2bsp.167644df7ad03132  6      Failed  Error: ImagePullBackOff  
INFO[2021-04-16T07:18:21Z] [odo]                                        
INFO[2021-04-16T07:18:21Z] [odo]                                        
INFO[2021-04-16T07:18:21Z] Deleting project: e2e-images-test133qyx

@dharmit
Copy link
Member Author

dharmit commented Apr 16, 2021

/test v4.7-integration-e2e

@prietyc123
Copy link
Contributor

@prietyc123 is the failure related to your proposed fix in #4630? Because it seems unrelated to code change in this PR:

No, its nowhere related to #4630 🙂 . Its a flake tracked #2877

@openshift-merge-robot openshift-merge-robot merged commit d5e4110 into redhat-developer:master Apr 16, 2021
@dharmit dharmit deleted the remove-travis branch April 18, 2021 13:29
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants