Creates service on cluster upon "odo push" #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
dharmit
requested review from
kadel and
valaparthvi
and removed request for
rnapoles-rh
dharmit
commented
Apr 22, 2021
| @@ -459,39 +465,5 @@ spec: | |||
| stdOut = helper.CmdShouldFail("odo", "unlink", "EtcdCluster/example") | |||
| Expect(stdOut).To(ContainSubstring("failed to unlink the service")) | |||
| }) | |||
|
|
|||
| It("should fail if we delete a link outside of odo (using oc)", func() { | |||
There was a problem hiding this comment.
Removing this test spec because it's about a scenario where the user does something outside the odo workflow.
4 tasks
|
Codewise, it looks good to me. I haven't been able to test functionality though, I couldn't get |
valaparthvi
approved these changes
Apr 22, 2021
|
/lgtm |
openshift-ci-robot
added
the
lgtm
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do / why we need it:
This PR ensures that an Opreator backed service is created on the cluster only when user does
odo pushand not when they doodo service create.Which issue(s) this PR fixes:
Fixes part of the scope mentioned in #4160 (comment)
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
Notes:
odo service create; odo pushworkflow for Operator backed services. Adding labels to the service, deleting service upon doingodo pushand Service Catalog related changes will come in subsequent PRs after this one is merged. Doing this to break big piece into smaller chunks.I need to add integration tests to the PR.Integration tests have been modified to useodo pushto actually create service on the cluster. Can't think of a new scenario that needs to be added. Open to ideas.How to test:
odo service createandodo push. Subsequentodo pushwould silently pass without any service info (because the service already exists on cluster.)