Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds component labels to Operator backed services #4656

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Adds component labels to Operator backed services #4656

merged 1 commit into from
Apr 27, 2021

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Apr 24, 2021

What type of PR is this?
/kind feature

What does this PR do / why we need it:
Adds component labels to Operator backed services. We will need this for:

Which issue(s) this PR fixes:

Fixes part of the scope mentioned in #4160 (comment)

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Notes

  • There's no integration test on this one because it's not a user facing change. Integration tests will be added in the PR for odo sevice list and odo service delete that use this PR.

How to test

  • Create an operator backed service by doing odo service create && odo push. For example - odo service create etcdoperator.v0.9.4-clusterwide/EtcdCluster myetcd && odo push. You could edit the service manifest in devfile.yaml and add labels to it and see if appending the labels works.
  • Check for labels - kubectl get EtcdCluster/myetcd -o yaml | less and check for .metadata.labels.

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Apr 24, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 24, 2021
@dharmit dharmit requested review from valaparthvi and kadel and removed request for rnapoles-rh April 24, 2021 15:51
@dharmit dharmit changed the base branch from master to main April 26, 2021 07:41
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, everything else looks good to me.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit daf4747 into redhat-developer:main Apr 27, 2021
@dharmit dharmit deleted the fix-4160-service-labels branch April 28, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants