Adds component labels to Operator backed services #4656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do / why we need it:
Adds component labels to Operator backed services. We will need this for:
odo service list
- to list services that belong to a component. Refer odo service create should add operator CR to the devfile #4160 (comment) for more details.odo service delete
- to delete services from cluster, we will compare the Kubernetes Inlined components in a devfile with the list of services belonging to the component on the clusterWhich issue(s) this PR fixes:
Fixes part of the scope mentioned in #4160 (comment)
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
Notes
odo sevice list
andodo service delete
that use this PR.How to test
odo service create && odo push
. For example -odo service create etcdoperator.v0.9.4-clusterwide/EtcdCluster myetcd && odo push
. You could edit the service manifest indevfile.yaml
and addlabels
to it and see if appending the labels works.kubectl get EtcdCluster/myetcd -o yaml | less
and check for.metadata.labels
.