Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add script for tests on IBMC #4877

Closed
wants to merge 0 commits into from
Closed

add script for tests on IBMC #4877

wants to merge 0 commits into from

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Jul 5, 2021 •
edited
Loading

Signed-off-by: anandrkskd anandrkskd@gmail.com

What type of PR is this?

/kind feature

What does this PR do / why we need it:

This PR adds script to run tests on Ibm cloud

Which issue(s) this PR fixes:

Fixes - part of #4412
Fixes - part of #4408

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

  • Update changelog

  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from prietyc123 and rnapoles-rh July 5, 2021 08:10
@anandrkskd anandrkskd mentioned this pull request Jul 5, 2021
Closed
4 tasks
@anandrkskd
Copy link
Contributor Author

/retest

1 similar comment
@anandrkskd
Copy link
Contributor Author

/retest

rnapoles-rh
rnapoles-rh reviewed Jul 7, 2021
View reviewed changes
Copy link
Contributor

@rnapoles-rh rnapoles-rh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

scripts/run_script_e2e.sh Outdated
# copy built odo to GOBIN
cp -avf ./odo $GOBIN_TEMP/
shout "getting ginkgo"
make goget-ginkgo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prietyc123 @anandrkskd I think that we do mot need make goget-ginkgo anymore, correct?

Copy link
Contributor Author

@anandrkskd anandrkskd Jul 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we need to do this because we are using different $GOBIN for each build.
yes won't need to do that I will update it!

@anandrkskd
Copy link
Contributor Author

/retest

1 similar comment
@anandrkskd
Copy link
Contributor Author

/retest

This was referenced Jul 8, 2021
Closed
Closed
@anandrkskd
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2021

@anandrkskd: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Jul 27, 2021 •
edited
Loading

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: 33fad0b

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/60ff9f8715b9ff0007ee0383

😎 Browse the preview: https://deploy-preview-4877--odo-docusaurus-preview.netlify.app

@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2021

@anandrkskd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v4.7-integration-e2e a08ab93 link /test v4.7-integration-e2e
ci/prow/unit a08ab93 link /test unit
ci/prow/psi-unit-test-windows a08ab93 link /test psi-unit-test-windows
ci/prow/psi-unit-test-mac a08ab93 link /test psi-unit-test-mac
ci/prow/psi-kubernetes-integration-e2e a08ab93 link /test psi-kubernetes-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anandrkskd anandrkskd closed this Jul 27, 2021
@anandrkskd anandrkskd force-pushed the tests/add-automation-script-IBMC branch from a08ab93 to 33fad0b Compare July 27, 2021 05:54
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@anandrkskd anandrkskd deleted the tests/add-automation-script-IBMC branch October 13, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnapoles-rh rnapoles-rh rnapoles-rh left review comments

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandrkskd @rnapoles-rh