Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline changes to use clusters in QE account #5448

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Pipeline changes to use clusters in QE account #5448

merged 1 commit into from
Feb 25, 2022

Conversation

rnapoles-rh
Copy link
Contributor

@rnapoles-rh rnapoles-rh commented Feb 9, 2022 •
edited
Loading

What type of PR is this:

/kind tests

What does this PR do / why we need it:
Added API_KEY_QE property to login to clusters in the IBM Cloud QE account. Will continue to use API_KEY to login to developer for log storage bucket, So now we need to login twice, first to QE account for cleanup and to connect to clusters and then to Developer account to upload logs

Which issue(s) this PR fixes:
No related issue

Fixes #5419

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Feb 9, 2022 •
edited
Loading

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: 41f4129

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6217be63e17363000867e667

😎 Browse the preview: https://deploy-preview-5448--odo-docusaurus-preview.netlify.app

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Feb 9, 2022
@openshift-ci openshift-ci bot requested review from cdrage and dharmit February 9, 2022 20:30
@rnapoles-rh rnapoles-rh requested review from feloy and removed request for dharmit and cdrage February 9, 2022 20:30
@odo-robot
Copy link

odo-robot bot commented Feb 9, 2022 •
edited
Loading

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2022 •
edited
Loading

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2022 •
edited
Loading

OpenShift Tests on commit finished with errors.
View logs: TXT HTML

@rnapoles-rh
Copy link
Contributor Author

/retest

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2022 •
edited
Loading

Kubernetes Tests on commit finished with errors.
View logs: TXT HTML

@anandrkskd
Copy link
Contributor

@rnapoles-rh I think you also need to update the powershell script.

@rnapoles-rh
Copy link
Contributor Author

You are right, I just pushed another commit

@rnapoles-rh rnapoles-rh added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 11, 2022
@kadel kadel added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering and removed kind/tests labels Feb 16, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Feb 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@odo-robot
Copy link

odo-robot bot commented Feb 24, 2022

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Feb 25, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Feb 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6b0d5b7 into redhat-developer:main Feb 25, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@rnapoles-rh @cdrage
Change to use API_KEY_QE (redhat-developer#5448)
96f0b84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy Awaiting requested review from feloy

Assignees

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use serviceID's in IBMCloud for testing
5 participants
@rnapoles-rh @anandrkskd @feloy @kadel @openshift-merge-robot