odo describe component

[feloy]

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5661

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

Doc preview: https://deploy-preview-5725--odo-docusaurus-preview.netlify.app/docs/3.0.0/command-reference/describe

[netlify]

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	cfdff49
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/627cb23bd6e4950009aaa109

[odo-robot]

Unit Tests on commit aa325c7 finished successfully.
View logs: TXT HTML

[odo-robot]

Windows Tests (OCP) on commit aa325c7 finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit aa325c7 finished successfully.
View logs: TXT HTML

[odo-robot]

OpenShift Tests on commit aa325c7 finished successfully.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit aa325c7 finished successfully.
View logs: TXT HTML

[valaparthvi]

The changes look good, I only have a few questions/suggestions.

[valaparthvi]

If you're going to be passing o.clientset.KubernetesClient, why not just pass that and calculate current namespace in the function? I think you can drop o.clientset.KubernetesClient.GetCurrentNamespace() arg, no?

Also, same comment for L110.

[valaparthvi]

Thank you for working on those changes, Philippe!

[rm3l]

LGTM, but I had a few small questions (might be enhancements for other PRs) :)

• In the "Running in" section, do we want to be more specific with the "Debug" Dev mode? Because the command displays "Dev" no matter if I run odo dev or odo dev --debug.
  I found it a bit strange given that the "Supported odo features" section clearly lists "Debug" as a possible feature supported, but this is currently not listed in "Running in" when running in this mode.

• Also, I understood that the "Supported odo features" information is determined from the current Devfile and currently displays "Unknown" when running with --name. When running with the --name flag, if a mode (Dev and/or Deploy) is detected and listed in the "Running in" section, it means that this feature is supported by odo, no?

❯ odo describe component --name my-app             
Name: my-app
Display Name: Unknown
Project Type: quarkus
Language: Unknown
Version: Unknown
Description: Unknown
Tags: 

Running in: Dev, Deploy

Supported odo features:
 •  Dev: Unknown
 •  Deploy: Unknown
 •  Debug: Unknown

[feloy]

LGTM, but I had a few small questions (might be enhancements for other PRs) :)

• In the "Running in" section, do we want to be more specific with the "Debug" Dev mode? Because the command displays "Dev" no matter if I run odo dev or odo dev --debug.
  I found it a bit strange given that the "Supported odo features" section clearly lists "Debug" as a possible feature supported, but this is currently not listed in "Running in" when running in this mode.

@kadel That's a good point, do we want to make the difference between the Dev and Debug modes for the running modes?

• Also, I understood that the "Supported odo features" information is determined from the current Devfile and currently displays "Unknown" when running with --name. When running with the --name flag, if a mode (Dev and/or Deploy) is detected and listed in the "Running in" section, it means that this feature is supported by odo, no?

I think the odo supported features are mostly intended to indicate that we can run the command "odo dev/deploy". Even if the component has been deployed, doesn't mean we can run it now (in this case, we couldn't, because we don't have the Devfile)

[rm3l]

• Also, I understood that the "Supported odo features" information is determined from the current Devfile and currently displays "Unknown" when running with --name. When running with the --name flag, if a mode (Dev and/or Deploy) is detected and listed in the "Running in" section, it means that this feature is supported by odo, no?

I think the odo supported features are mostly intended to indicate that we can run the command "odo dev/deploy". Even if the component has been deployed, doesn't mean we can run it now (in this case, we couldn't, because we don't have the Devfile)

Okay, I see. Thanks.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[valaparthvi]

/lgtm

[rm3l]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rm3l]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment