Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for composite run/debug commands #5841

Commits on Jun 21, 2022

  1. Configuration menu
    Copy the full SHA
    38cd1e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8b5b24 View commit details
    Browse the repository at this point in the history
  3. Rename in-container pid file from '.odo_devfile_cmd_<name>.pid' into …

    …'.odo_cmd_<name>.pid'
    
    The implementation in kubeexec.go is indeed able to run any kind of commands,
    not only Devfile-related.
    rm3l committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    bd9e2d4 View commit details
    Browse the repository at this point in the history
  4. Pave the way to supporting composite run/debug commands

    Drop validation rules that prevented from going further
    with composite run or debug commands.
    rm3l committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    5c568b0 View commit details
    Browse the repository at this point in the history
  5. Update logic for determining which containers should have their entry…

    …point overridden or env vars updated
    
    The previous implementation was limited to Exec commands solely.
    This now makes it easier to support other kind of commands.
    For example, when handling a composite command, we are now recursively
    determining the containers (a.k.a components) that would get used by this composite command.
    rm3l committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    94a170e View commit details
    Browse the repository at this point in the history
  6. Store the process exit code in the pid file handled by kubeexec.go

    This allows to more accurately determine how the process could be reported.
    rm3l committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b4e83ac View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8595906 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Configuration menu
    Copy the full SHA
    7f136cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c63ecf7 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Configuration menu
    Copy the full SHA
    25d0223 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0402a05 View commit details
    Browse the repository at this point in the history
  3. Redirect build command logs to PID 1 process

    This way, users would be able to display them (and follow them) with `odo logs` or `kubectl logs`
    rm3l committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    966b14f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5f63fe3 View commit details
    Browse the repository at this point in the history
  5. Make sure to override container entrypoint if needed for Build commands

    Build commands (which could also be composite ones)
    might be executed in a container different from the run or debug ones.
    rm3l committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    04cb064 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Redirect output from commands handled by component.exec_handler to PI…

    …D 1 process streams
    
    This way, we can also have them displayed with `odo logs` or `kubectl logs`.
    This includes Build and Devfile events commands.
    rm3l committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    a5b95d9 View commit details
    Browse the repository at this point in the history
  2. Make remotecmd#ExecuteCommand log stdout or stderr content only if th…

    …ere not empty
    
    This reduces the clutter in case of an error with the command execution.
    rm3l committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    251e9b4 View commit details
    Browse the repository at this point in the history
  3. Add integration test with more complex Devfile (composite build/run/d…

    …ebug commands running in different containers and with a shared volume)
    rm3l committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    3c14855 View commit details
    Browse the repository at this point in the history
  4. Update the 'Executing the application' spinner accordingly when the r…

    …elated command is done
    rm3l committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    f3bb6cf View commit details
    Browse the repository at this point in the history