-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for composite run/debug commands #5841
Add support for composite run/debug commands #5841
Commits on Jun 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 38cd1e6 - Browse repository at this point
Copy the full SHA 38cd1e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8b5b24 - Browse repository at this point
Copy the full SHA c8b5b24View commit details -
Rename in-container pid file from '.odo_devfile_cmd_<name>.pid' into …
…'.odo_cmd_<name>.pid' The implementation in kubeexec.go is indeed able to run any kind of commands, not only Devfile-related.
Configuration menu - View commit details
-
Copy full SHA for bd9e2d4 - Browse repository at this point
Copy the full SHA bd9e2d4View commit details -
Pave the way to supporting composite run/debug commands
Drop validation rules that prevented from going further with composite run or debug commands.
Configuration menu - View commit details
-
Copy full SHA for 5c568b0 - Browse repository at this point
Copy the full SHA 5c568b0View commit details -
Update logic for determining which containers should have their entry…
…point overridden or env vars updated The previous implementation was limited to Exec commands solely. This now makes it easier to support other kind of commands. For example, when handling a composite command, we are now recursively determining the containers (a.k.a components) that would get used by this composite command.
Configuration menu - View commit details
-
Copy full SHA for 94a170e - Browse repository at this point
Copy the full SHA 94a170eView commit details -
Store the process exit code in the pid file handled by kubeexec.go
This allows to more accurately determine how the process could be reported.
Configuration menu - View commit details
-
Copy full SHA for b4e83ac - Browse repository at this point
Copy the full SHA b4e83acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8595906 - Browse repository at this point
Copy the full SHA 8595906View commit details
Commits on Jun 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7f136cd - Browse repository at this point
Copy the full SHA 7f136cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c63ecf7 - Browse repository at this point
Copy the full SHA c63ecf7View commit details
Commits on Jun 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 25d0223 - Browse repository at this point
Copy the full SHA 25d0223View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0402a05 - Browse repository at this point
Copy the full SHA 0402a05View commit details -
Redirect build command logs to PID 1 process
This way, users would be able to display them (and follow them) with `odo logs` or `kubectl logs`
Configuration menu - View commit details
-
Copy full SHA for 966b14f - Browse repository at this point
Copy the full SHA 966b14fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f63fe3 - Browse repository at this point
Copy the full SHA 5f63fe3View commit details -
Make sure to override container entrypoint if needed for Build commands
Build commands (which could also be composite ones) might be executed in a container different from the run or debug ones.
Configuration menu - View commit details
-
Copy full SHA for 04cb064 - Browse repository at this point
Copy the full SHA 04cb064View commit details
Commits on Jun 24, 2022
-
Redirect output from commands handled by component.exec_handler to PI…
…D 1 process streams This way, we can also have them displayed with `odo logs` or `kubectl logs`. This includes Build and Devfile events commands.
Configuration menu - View commit details
-
Copy full SHA for a5b95d9 - Browse repository at this point
Copy the full SHA a5b95d9View commit details -
Make remotecmd#ExecuteCommand log stdout or stderr content only if th…
…ere not empty This reduces the clutter in case of an error with the command execution.
Configuration menu - View commit details
-
Copy full SHA for 251e9b4 - Browse repository at this point
Copy the full SHA 251e9b4View commit details -
Add integration test with more complex Devfile (composite build/run/d…
…ebug commands running in different containers and with a shared volume)
Configuration menu - View commit details
-
Copy full SHA for 3c14855 - Browse repository at this point
Copy the full SHA 3c14855View commit details -
Update the 'Executing the application' spinner accordingly when the r…
…elated command is done
Configuration menu - View commit details
-
Copy full SHA for f3bb6cf - Browse repository at this point
Copy the full SHA f3bb6cfView commit details