Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build-command flag to odo dev to run non-default Build command #5891

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Add build-command flag to odo dev to run non-default Build command #5891

merged 4 commits into from
Jun 29, 2022

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jun 28, 2022 •
edited
Loading

What type of PR is this:
/kind feature
/area dev

What does this PR do / why we need it:
This adds a build-command flag to odo dev. See #5776 for more context.

Which issue(s) this PR fixes:
Fixes #5776

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
odo dev --build-command <command> should allow to build the application using the specified <command>, provided it is in the build group.

rm3l added 3 commits June 28, 2022 17:50
@rm3l
Add integration test cases
03390b2
@rm3l
Add documentation
dd3596d
@rm3l
Add build-command flag to odo dev
c22bdd6 
This allows to build applications using a non-default build command.
@netlify
Copy link

netlify bot commented Jun 28, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 0d48bde
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62bc0a7f1c066a00095c2925
😎 Deploy Preview https://deploy-preview-5891--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rm3l rm3l requested a review from feloy June 28, 2022 15:56
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 28, 2022
@rm3l rm3l requested review from dharmit and removed request for feloy June 28, 2022 15:56
@openshift-ci openshift-ci bot added the area/dev Issues or PRs related to `odo dev` label Jun 28, 2022
@openshift-ci openshift-ci bot requested review from feloy and rnapoles-rh June 28, 2022 15:56
@rm3l rm3l requested review from valaparthvi and cdrage and removed request for rnapoles-rh June 28, 2022 15:56
@odo-robot
Copy link

odo-robot bot commented Jun 28, 2022 •
edited
Loading

OpenShift Tests on commit a0621a7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2022 •
edited
Loading

Kubernetes Tests on commit a0621a7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2022 •
edited
Loading

Windows Tests (OCP) on commit a0621a7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 29, 2022 •
edited
Loading

Unit Tests on commit a0621a7 finished successfully.
View logs: TXT HTML

feloy
feloy reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

docs/website/docs/command-reference/dev.md Outdated Show resolved Hide resolved
@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jun 29, 2022
@odo-robot
Copy link

odo-robot bot commented Jun 29, 2022 •
edited
Loading

Validate Tests on commit a0621a7 finished successfully.
View logs: TXT HTML

@rm3l @feloy
Update docs/website/docs/command-reference/dev.md
0d48bde 
Co-authored-by: Philippe Martin <contact@elol.fr>
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dharmit
Copy link
Member

dharmit commented Jun 29, 2022

/lgtm

Since IBM Cloud OCP tests are passing, overriding prow tests
/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2022

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/v4.10-integration-e2e

In response to this:

/lgtm

Since IBM Cloud OCP tests are passing, overriding prow tests
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 29, 2022
@openshift-ci openshift-ci bot merged commit 63754d0 into redhat-developer:main Jun 29, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@rm3l @feloy @cdrage
Add build-command flag to odo dev to run non-default Build command (
b03fcf3 
redhat-developer#5891)

* Add integration test cases

* Add documentation

* Add `build-command` flag to `odo dev`

This allows to build applications using a non-default build command.

* Update docs/website/docs/command-reference/dev.md

Co-authored-by: Philippe Martin <contact@elol.fr>

Co-authored-by: Philippe Martin <contact@elol.fr>
@rm3l rm3l deleted the 5776-odo-dev-add-flag-to-run-non-default-build-command branch December 1, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy left review comments

@dharmit dharmit Awaiting requested review from dharmit

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

@cdrage cdrage Awaiting requested review from cdrage

Assignees

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/dev Issues or PRs related to `odo dev` kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo dev add flag to run non-default build command.
3 participants
@rm3l @dharmit @feloy