Allow using remote Dockerfiles (HTTP(S) only) for building images #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Dockerfile For now, this only supports HTTP(S) and downloads the remote file to a temporary file. The path to that temp. file is then returned to the caller. In all other cases, the specified URI path is returned as is. This means that non-HTTP(S) URIs will *not* get resolved, but will be returned as is. Signed-off-by: Armel Soro <asoro@redhat.com>
…images` commands Signed-off-by: Armel Soro <asoro@redhat.com>
… is relative It actually does not make sense to join absolute Dockerfile paths, as can be the case with temporary files created by downloading a remote Dockerfile Signed-off-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Armel Soro <asoro@redhat.com>
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
the
kind/feature
dharmit
suggested changes
Jul 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
…olve a Dockerfile
…`build-images` commands Signed-off-by: Armel Soro <asoro@redhat.com>
dharmit
reviewed
Jul 29, 2022
pkg/devfile/image/image.go
Outdated
| @@ -89,7 +90,7 @@ func buildPushImage(backend Backend, image *devfile.ImageComponent, devfilePath | |||
| // selectBackend selects the container backend to use for building and pushing images | |||
| // It will detect podman and docker CLIs (in this order), | |||
| // or return an error if none are present locally | |||
| func selectBackend() (Backend, error) { | |||
| func selectBackend(fs filesystem.Filesystem) (Backend, error) { | |||
There was a problem hiding this comment.
Don't find this change comfortable. Actually selectBackend has no need for the fs. It's doing something else along with trying to figure out the backend to use, and hence it now needs this extra param.
There was a problem hiding this comment.
Makes sense. Instead, I moved this parameter to the Build method in the image.Backend interface. This is where it is actually needed, when trying to build the image.
See 878285b (#5976)
|
/lgtm |
openshift-ci
bot
added
the
lgtm
…`build-images` commands
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
openshift-ci
bot
added
the
lgtm
cdrage
pushed a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
…dhat-developer#5976) * Add utility function in `docker_compatible.go` allowing to resolve a Dockerfile For now, this only supports HTTP(S) and downloads the remote file to a temporary file. The path to that temp. file is then returned to the caller. In all other cases, the specified URI path is returned as is. This means that non-HTTP(S) URIs will *not* get resolved, but will be returned as is. Signed-off-by: Armel Soro <asoro@redhat.com> * Allow using remote HTTP(S) Dockerfiles with both `deploy` and `build-images` commands Signed-off-by: Armel Soro <asoro@redhat.com> * Join resolved Dockerfile path with the Devfile one only if the former is relative It actually does not make sense to join absolute Dockerfile paths, as can be the case with temporary files created by downloading a remote Dockerfile Signed-off-by: Armel Soro <asoro@redhat.com> * Add integration test cases for `odo build-images` Signed-off-by: Armel Soro <asoro@redhat.com> * Add integration test cases for `odo deploy` Signed-off-by: Armel Soro <asoro@redhat.com> * Update doc for both `build-images` and `deploy` commands Signed-off-by: Armel Soro <asoro@redhat.com> * fixup! Add utility function in `docker_compatible.go` allowing to resolve a Dockerfile * fixup! Allow using remote HTTP(S) Dockerfiles with both `deploy` and `build-images` commands Signed-off-by: Armel Soro <asoro@redhat.com> * fixup! Allow using remote HTTP(S) Dockerfiles with both `deploy` and `build-images` commands * fixup! 878285b
rm3l
deleted the
5450-using-odo-deploy-remote-dockerfile-uri-not-accesible-https-not-supported
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
This PR adds support for remote Dockerfiles (specified via an HTTP or HTTPS URL) when running
odo build-imagesorodo deploy.Which issue(s) this PR fixes:
Fixes #5450
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
See the reproduction steps provided in #5450 for functional testing.
From the code perspective, commits in this branch are atomic and self-contained. This PR can be reviewed on a commit-by-commit basis.