Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more checks to check-fit.sh #6001

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

valaparthvi
Copy link
Contributor

Signed-off-by: Parthvi Vala pvala@redhat.com

What type of PR is this:
/kind tests

What does this PR do / why we need it:
This PR adds more checks to check-fit.sh script.

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

  1. Add focus to your tests by adding F to your specs.(https://onsi.github.io/ginkgo/#focused-specs)
  2. Run the script and see if it detects them.

Signed-off-by: Parthvi Vala <pvala@redhat.com>
@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 02a37bd
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62ea4608fc8334000965d0a6

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@anandrkskd
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandrkskd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 3, 2022
@odo-robot
Copy link

odo-robot bot commented Aug 3, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor Author

valaparthvi commented Aug 3, 2022

/override Unit Tests/Unit Tests

Never thought I'd say this, but prow job passes!

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: Unit Tests/Unit Tests

In response to this:

/override Unit Tests/Unit Tests

Never thought I'd say this, but prow job passes 😂

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 6fb5cc8 into redhat-developer:main Aug 3, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants