Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ginkgo to v2.1.6 #6072

Merged

Conversation

anandrkskd
Copy link
Contributor

Signed-off-by: anandrkskd anandrkskd@gmail.com

What type of PR is this:

/kind tests

What does this PR do / why we need it:
This PR updates ginkgo version to 2.1.6. This will fix the no test summary for single test case failure on PRs and periodic jobs.

Which issue(s) this PR fixes:

Fixes #5874

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

go get -u github.com/onsi/ginkgo/v2
go mod vendor
go mod tidy
go mod tidy -compat=1.17

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 7f9649a
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/631055b535b5cf0008557509

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@anandrkskd
Copy link
Contributor Author

/retest

@anandrkskd
Copy link
Contributor Author

/test unit-and-validate-test

@dharmit
Copy link
Member

dharmit commented Sep 1, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 1, 2022
@feloy
Copy link
Contributor

feloy commented Sep 1, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 1, 2022
@feloy
Copy link
Contributor

feloy commented Sep 1, 2022

Thanks @anandrkskd for the description how the go.mod file has been changed

@feloy
Copy link
Contributor

feloy commented Sep 1, 2022

/override ci/prow/unit-and-validate-test
Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit-and-validate-test

In response to this:

/override ci/prow/unit-and-validate-test
Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 2337f4d into redhat-developer:main Sep 1, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Sep 7, 2022
Signed-off-by: anandrkskd <anandrkskd@gmail.com>

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd anandrkskd deleted the fix-test-stats branch October 13, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odo test statistics are broken
4 participants