Manual sync of files pressing p

[feloy]

What type of PR is this:

/kind feature

What does this PR do / why we need it:

This PR configures the terminal to work in Character mode, instead of the default Line mode. Read() will return as soon as a character is sent to the input stream, instead of waiting for a newline character.

code refactoring:

• moved getFullSourcesWatcher and related functions to a specific file file_watcher.go
• moved long list of watchers variables into receiver instead of passing as parameters

Which issue(s) this PR fixes:

Fixes #5634

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

• odo dev will fail to configure terminal on Windows/cygwin terminal.

  You can use $ winpty odo dev to fix the problem

  https://bryantson.medium.com/troubleshooting-make-raw-terminal-failed-the-handle-is-invalid-57b7e1d9b12b

• Windows terminal seetings
  https://docs.microsoft.com/en-us/windows/console/setconsolemode

• Unix terminal settings:
  https://man7.org/linux/man-pages/man3/termios.3.html

Refactoring integration tests

Some tests were calling devSession.Kill() (or Stop()) twice, which makes ginkgo stop abrupty during the second call on Windows.

In the following example, the Kill in AfterEach is necessary for the cleanup after test1, but is problematic for test2, as Stop has been called before.

As the AfterEach/BeforeEach are evaluated at the beginning, it is not possible to rely on a field in devSession to record if the method has already been called.

When("odo dev is executed", func() {

			var devSession helper.DevSession

			BeforeEach(func() {
				var err error
				devSession, _, _, _, err = helper.StartDevMode(nil)
				Expect(err).ToNot(HaveOccurred())
			})

			AfterEach(func() {
				devSession.Kill()
				devSession.WaitEnd()
			})

			It("test 1", func() { ... })

			When("odo dev is stopped", func() {
				BeforeEach(func() {
					devSession.Stop()
					devSession.WaitEnd()
				})

				It("test 2", func() { ... })
			})
		})

These tests have been split in two trees, separating test1 and test2, to be able to call Kill/Stop only once.

[netlify]

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	406923f
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/631b4d961766d50009374924
😎 Deploy Preview	https://deploy-preview-6089--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[odo-robot]

Unit Tests on commit 978f45b finished successfully.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit 978f45b finished successfully.
View logs: TXT HTML

[odo-robot]

OpenShift Tests on commit 978f45b finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit 978f45b finished successfully.
View logs: TXT HTML

[feloy]

Blocked by #6091

[odo-robot]

Windows Tests (OCP) on commit 978f45b finished successfully.
View logs: TXT HTML

[rm3l]

Thanks for your work on this. Added a few code-related comments I had so far.

[feloy]

Thanks @rm3l for your review

[feloy]

/hold Windows tests are failing on CI (non required)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[feloy]

@anandrkskd I've added a PR to fix the problem of failing integration tests on Windows

[feloy]

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM cloud

[openshift-ci]

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.