Port-forward all endpoints regardless of exposure #6119
Conversation
Defining endpoints for Debug ports is required for Devfiles to work properly with `odo dev --debug`. This addresses the question of exposure for such endpoints. Tools like DevSpaces currently set 'exposure: none' for debug endpoints. This makes sense from the developer perspective, as 'odo dev' aims at emulating a local developer machine. As a consequence, `odo dev` should no longer ignore endpoints with 'exposure: none'. They should be port-forwarded just like other endpoints.
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
/override ci/prow/v4.10-integration-e2e Tests are passing in IBM Cloud. |
|
@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rm3l
deleted the
5988-registry-devfiles-are-incompatible-with-odo-dev-debug
branch
…at-developer#6119) Defining endpoints for Debug ports is required for Devfiles to work properly with `odo dev --debug`. This addresses the question of exposure for such endpoints. Tools like DevSpaces currently set 'exposure: none' for debug endpoints. This makes sense from the developer perspective, as 'odo dev' aims at emulating a local developer machine. As a consequence, `odo dev` should no longer ignore endpoints with 'exposure: none'. They should be port-forwarded just like other endpoints.
What type of PR is this:
/kind bug
What does this PR do / why we need it:
This removes the condition that caused endpoints with
exposure: noneto be ignored. Nowodo devshould port-forward all endpoints, regardless of the exposure.This is needed as part of #5988: a separate PR in the Devfile registry will add endpoints for debug ports to all relevant Devfiles.
Which issue(s) this PR fixes:
ref #5988
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
Endpoints with
exposure: noneshould be port-forwarded, just like any other endpoint.