Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow controlling telemetry via the ODO_TRACKING_CONSENT environment variable #6258

Merged
merged 11 commits into from
Oct 31, 2022
Merged

Allow controlling telemetry via the ODO_TRACKING_CONSENT environment variable #6258

merged 11 commits into from
Oct 31, 2022

Commits on Oct 31, 2022

  1. Add support for ODO_TRACKING_CONSENT env variable 

    Co-authored-by: Armel Soro <asoro@redhat.com>
    @kadel @rm3l
    kadel and rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    54d5273 View commit details
    Browse the repository at this point in the history

  2. Replace deprecated 'ODO_DISABLE_TELEMETRY' env var with 'ODO_TRACKING… 

    …_CONSENT' in integration tests
    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    de7c17c View commit details
    Browse the repository at this point in the history

  3. Log environment of process launched with 'helper_run' in integration … 

    …tests

`odo` behavior might be altered based on certain environment variables.
So this is to help debug future issues that might happen.

Because the process environment also contains the
current OS environment, we purposely limit the content
to variables prefixed with 'ODO_' or particular ones
(like 'TELEMETRY_CALLER').
    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    5758651 View commit details
    Browse the repository at this point in the history

  4. Test conflicting situations when using both 'ODO_DISABLE_TELEMETRY' a… 

    …nd 'ODO_TRACKING_CONSENT'
    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    f227bd2 View commit details
    Browse the repository at this point in the history

  5. Disable golangci-lint 'staticcheck' check about using the deprecated … 

    …'segment.DisableTelemetryEnv'

However, due to [1], line-based directives do not seem to be working.
    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    80740f6 View commit details
    Browse the repository at this point in the history

  6. Make ODO_TRACKING_CONSENT env var take precedence over the ConsentTel… 

    …emetry preference

See [1] for more context.

[1] https://github.com/redhat-developer/odo/pull/6258\#issuecomment-1293736398
    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    e9f5f0e View commit details
    Browse the repository at this point in the history

  7. Add new 'segment#isTrackingConsentEnabled' function, as suggested in … 

    …review

This would make it easier to rename the values if needed or add aliases later.
    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    ec9cd87 View commit details
    Browse the repository at this point in the history

  8. Add more unit test cases, especially when any of the telemetry var is… 

    … not there in the env
    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    66846ed View commit details
    Browse the repository at this point in the history

  9. Document ODO_TRACKING_CONSENT

    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    f014337 View commit details
    Browse the repository at this point in the history

  10. fixup! Add new 'segment#isTrackingConsentEnabled' function, as sugges… 

    …ted in review
    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    a4415ec View commit details
    Browse the repository at this point in the history

  11. fixup! fixup! Add new 'segment#isTrackingConsentEnabled' function, as… 

    … suggested in review
    @rm3l
    rm3l committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    8b69040 View commit details
    Browse the repository at this point in the history